Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-09-29 Thread Jim Meyering
Rod Smith wrote: > On 09/23/2012 03:46 PM, Jim Meyering wrote: >> >> Rod, >> >> Better late than never... >> Here is your patch, with modifications to the log (please double >> check it for grammar), and to the code for consistency in space-vs-TAB >> indentation. I have also added the fix that is

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-09-28 Thread Rod Smith
On 09/23/2012 03:46 PM, Jim Meyering wrote: Rod, Better late than never... Here is your patch, with modifications to the log (please double check it for grammar), and to the code for consistency in space-vs-TAB indentation. I have also added the fix that is required to keep this change from ca

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-09-23 Thread Jim Meyering
Rod Smith wrote: > On 03/06/2012 04:21 AM, Jim Meyering wrote: >> Keshav P R wrote: >>> Status of Rod's patch? >> >> It breaks one of the "make check" tests, and I suggested how to fix that. >> It did not update NEWS or documentation, and it did not add any >> test case of its own. > > I made

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-03-13 Thread Chris Murphy
On Mar 6, 2012, at 9:54 AM, Rod Smith wrote: > On 03/06/2012 04:21 AM, Jim Meyering wrote: >> Keshav P R wrote: >>> Status of Rod's patch? >> >> It breaks one of the "make check" tests, and I suggested how to fix that. >> It did not update NEWS or documentation, and it did not add any >> tes

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-03-06 Thread Rod Smith
On 03/06/2012 04:21 AM, Jim Meyering wrote: Keshav P R wrote: Status of Rod's patch? It breaks one of the "make check" tests, and I suggested how to fix that. It did not update NEWS or documentation, and it did not add any test case of its own. I made all those changes except for the te

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-03-06 Thread Jim Meyering
Keshav P R wrote: >     Status of Rod's patch? It breaks one of the "make check" tests, and I suggested how to fix that. It did not update NEWS or documentation, and it did not add any test case of its own. > I suggest a similar "linuxdata" flag to set a partitoon as Linux Data > type irrespectiv

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2012-03-05 Thread Keshav P R
Hi,     Status of Rod's patch? I suggest a similar "linuxdata" flag to set a partitoon as Linux Data type irrespective of the unserlyting FS. I also recommend changing "boot" flag in parted for GPT disk to something more meaningful like "uefisys". Many devs (of distro installers) are confused as t

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-09-29 Thread Jim Meyering
KESHAV P.R. wrote: > On Sun, Sep 11, 2011 at 16:23, KESHAV P.R. wrote: >> On Sat, Aug 6, 2011 at 14:28, Jim Meyering wrote: >>> Rod Smith wrote: It took the FSF quite some time to get the forms to me, but I've filled them out, sent them back, and received confirmation from them >>>

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-09-29 Thread KESHAV P.R.
On Sun, Sep 11, 2011 at 16:23, KESHAV P.R. wrote: > On Sat, Aug 6, 2011 at 14:28, Jim Meyering wrote: >> Rod Smith wrote: >>> >>> It took the FSF quite some time to get the forms to me, but I've >>> filled them out, sent them back, and received confirmation from them >>> that they're now on file,

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-09-11 Thread KESHAV P.R.
On Sat, Aug 6, 2011 at 14:28, Jim Meyering wrote: > Rod Smith wrote: >> >> It took the FSF quite some time to get the forms to me, but I've >> filled them out, sent them back, and received confirmation from them >> that they're now on file, so please feel free to apply the last patch >> I submitte

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-08-06 Thread Jim Meyering
Rod Smith wrote: > On 06/27/2011 04:41 PM, Jim Meyering wrote: >> Rod Smith wrote: >>> I'm attaching another patch that should be applied INSTEAD OF my >>> earlier patch in order to support a new Linux-only GUID type code. > ... >> Thanks for the improved patch. > ... >> Your change is large enough

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-08-04 Thread Rod Smith
On 06/27/2011 04:41 PM, Jim Meyering wrote: Rod Smith wrote: I'm attaching another patch that should be applied INSTEAD OF my earlier patch in order to support a new Linux-only GUID type code. ... Thanks for the improved patch. ... Your change is large enough that in order for us to be able

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-28 Thread Rod Smith
On 06/27/2011 04:41 PM, Jim Meyering wrote: Thanks for the improved patch. If you include the following, the result will then pass "make check": ... Your change is large enough that in order for us to be able to use it, we'll need a copyright assignment. See the "Copyright assignment" section

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-27 Thread Jim Meyering
KESHAV P.R. wrote: > Apart from changing the default GUID in libparted and gdisk, I > also think the kernel devs should be notified of this change. > Specifically it should be changed at > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=fs/partitions/efi.h;hb=HE

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-27 Thread Jim Meyering
Rod Smith wrote: > I'm attaching another patch that should be applied INSTEAD OF my > earlier patch in order to support a new Linux-only GUID type code. The > new patch is intended to address concerns about breaking programs that > might assume the Microsoft Basic Data partition type code on Linux

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-27 Thread Brian C. Lane
On Sat, Jun 25, 2011 at 04:05:29PM -0400, Rod Smith wrote: > Hi, > > I'm attaching another patch that should be applied INSTEAD OF my > earlier patch in order to support a new Linux-only GUID type code. > The new patch is intended to address concerns about breaking > programs that might assume the

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-27 Thread KESHAV P.R.
Hi, Apart from changing the default GUID in libparted and gdisk, I also think the kernel devs should be notified of this change. Specifically it should be changed at http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=fs/partitions/efi.h;hb=HEAD . I think PARTITION

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-26 Thread KESHAV P.R.
Hi, I have been following this discussion closely. Rod Smith, thanks for bringing this up. I would also suggesta similar "linuxdata" flag to set a partitoon as Linux Data type irrespective of the unserlyting FS. I alos recommend changing "boot" flag in parted for GPT disk to something more mea

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-25 Thread Rod Smith
Hi, I'm attaching another patch that should be applied INSTEAD OF my earlier patch in order to support a new Linux-only GUID type code. The new patch is intended to address concerns about breaking programs that might assume the Microsoft Basic Data partition type code on Linux partitions by g

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-24 Thread jdd
Le 24/06/2011 11:45, Bryn M. Reeves a écrit : I would expect that (in the same way as I would expect our tools to be able to remove partitions containing unknown Windows file systems even if they cannot do anything useful with them). my linux, at least, identify correctly the filesystem inclu

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-24 Thread Bryn M. Reeves
On 06/24/2011 07:13 AM, jdd wrote: > Le 24/06/2011 02:14, Rod Smith a écrit : > > 7, using something other than the Microsoft Basic Data GUID code does >> hide the partition from the Computer window, and the Disk Management >> tool grays out the option to format the volume. Feel free to > > I j

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread jdd
Le 24/06/2011 02:14, Rod Smith a écrit : 7, using something other than the Microsoft Basic Data GUID code does hide the partition from the Computer window, and the Disk Management tool grays out the option to format the volume. Feel free to I just fired my windows 7 to see. Partitions are not

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Rod Smith
jdd wrote: With MBR disks, this problem doesn't occur, because Linux has its own unique partition type code (0x83), and Windows doesn't try to access partition types it doesn't understand. windows always flag as free and formatable a linux partition as far as I know I could have s

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread jdd
Le 23/06/2011 20:43, Brian C. Lane a écrit : This seems like a good idea. But I worry about tools and other OS's that expect the current behavior. And as Jim pointed out we don't always have a Linux filesystem on partitions we create. so why using a flag according to the filesystem type is goo

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread jdd
Le 23/06/2011 17:46, Rod Smith a écrit : Yes, that's the whole point. In Windows, using the same GUID type code for Linux partitions that Windows uses for NTFS and FAT results in Linux partitions appearing in the list of available disks. Using a unique type code for Linux partitions, however, hi

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Rod Smith
On 06/23/2011 02:43 PM, Brian C. Lane wrote: On Thu, Jun 23, 2011 at 12:38:10AM -0400, Rod Smith wrote: Hi, I've recently discovered that when Windows reads a GPT disk with Linux partitions on it, those partitions are given drive letters and show up as unformatted. This situation can happen wit

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Rod Smith
On 06/23/2011 02:18 PM, Jim Meyering wrote: Rod Smith wrote: Thus, it seems to me that Linux needs its own partition type code GUID for filesystem partitions on GPT disks, much as it has its own MBR partition type code for filesystems (0x83 on MBR). I'd like to implement such a change in my own

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Brian C. Lane
On Thu, Jun 23, 2011 at 12:38:10AM -0400, Rod Smith wrote: > Hi, > > I've recently discovered that when Windows reads a GPT disk with > Linux partitions on it, those partitions are given drive letters and > show up as unformatted. This situation can happen with removable > disks or when Linux and

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Jim Meyering
Rod Smith wrote: > I've recently discovered that when Windows reads a GPT disk with Linux > partitions on it, those partitions are given drive letters and show up > as unformatted. This situation can happen with removable disks or when > Linux and Windows dual-boot on a UEFI-based computer. Because

re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-23 Thread Rod Smith
jdd wrote: Le 23/06/2011 06:38, Rod Smith a écrit : At the risk of jumping the gun, I'm attaching a patch to implement my suggestion in libparted. did you test it with windows? Because in non GPT disk, Windows never acknoledge Linux drives, but always ask for formatting. I have no

Re: Need for a unique Linux GPT GUID type code (PATCH included)

2011-06-22 Thread jdd
Le 23/06/2011 06:38, Rod Smith a écrit : At the risk of jumping the gun, I'm attaching a patch to implement my suggestion in libparted. did you test it with windows? Because in non GPT disk, Windows never acknoledge Linux drives, but always ask for formatting. I have no GPT disk to try tha