-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 05/05/2014 07:32 PM, Brian C. Lane wrote:
>> Just noticed I didn't Cc you on this, was that an ack on this one
>> with the fixed test?
>
> Yes. Also, I'm on the lists so no need for explicit cc's
Patch pushed.
-BEGIN PGP SIGNATURE-
Vers
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 04/18/2014 06:55 PM, Phillip Susi wrote:
> I could have sworn I fixed that test before, but here it is
>
> 8<>8
>
> gpt was using a static local variable to suppress repeatedly
> reporting an error if you chose to ign
I could have sworn I fixed that test before, but here it is
8<>8
gpt was using a static local variable to suppress repeatedly reporting
an error if you chose to ignore it. This is incorrect as the variable is
global to all disks, and ignoring the error on one should n
On Sat, Mar 29, 2014 at 01:50:12PM -0400, Phillip Susi wrote:
> gpt was using a static local variable to suppress repeatedly reporting
> an error if you chose to ignore it. This is incorrect as the variable is
> global to all disks, and ignoring the error on one should not suppress its
> reporting
gpt was using a static local variable to suppress repeatedly reporting
an error if you chose to ignore it. This is incorrect as the variable is
global to all disks, and ignoring the error on one should not suppress its
reporting on another. Moving the flag to the PedDisk object made it
effectivel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 03/03/2014 03:06 PM, Brian C. Lane wrote:
> On Sun, Jan 05, 2014 at 11:03:55PM -0500, Phillip Susi wrote:
>> Command* command_create (const StrList* names, - int (*method)
>> (PedDevice** dev), + int (*method) (PedDevice** dev,
On Sun, Jan 05, 2014 at 11:03:55PM -0500, Phillip Susi wrote:
> Command*
> command_create (const StrList* names,
> - int (*method) (PedDevice** dev),
> + int (*method) (PedDevice** dev, PedDisk** disk),
May as well call the argument diskp everywhere to be consistent.
> @
gpt was using a static local variable to suppress repeatedly reporting
an error if you chose to ignore it. This is incorrect as the variable is
global to all disks, and ignoring the error on one should not suppress its
reporting on another. Moving the flag to the PedDisk object made it
effectivel
