Re: [PATCH] Default to 1MiB alignment when possible (#618255)

2010-12-15 Thread Jim Meyering
Brian C. Lane wrote: > On Wed, Dec 15, 2010 at 11:10:46AM +0100, Jim Meyering wrote: > > Thanks for the changes, I especially like the operators aligned at the > start. :-) I'll take that as an ACK, and have pushed the change. ___ bug-parted mailing li

Re: [PATCH] Default to 1MiB alignment when possible (#618255)

2010-12-15 Thread Brian C. Lane
On Wed, Dec 15, 2010 at 11:10:46AM +0100, Jim Meyering wrote: Thanks for the changes, I especially like the operators aligned at the start. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) pgplNuVeZVnnf.pgp Description: PGP signature __

Re: [PATCH] Default to 1MiB alignment when possible (#618255)

2010-12-15 Thread Jim Meyering
Brian C. Lane wrote: > To better support 4k sector drives this changes the > linux_get_optimum_alignment() function to prefer aligning partitions to > DEFAULT_ALIGNMENT (1048576) if possible. > > This also modifies the alignment test to take this change into account. > --- > include/parted/parted.

Re: [PATCH] Default to 1MiB alignment when possible (#618255)

2010-12-13 Thread Håkon Løvdal
On 10 December 2010 20:26, Brian C. Lane wrote: > +#define DEFAULT_ALIGNMENT       1048576 Could we instead have this as #define DEFAULT_ALIGNMENT (1024 * 1024) because to me 1048576 appears to be a magic number and while I understand that this number is highly unlikely to be anything oth

[PATCH] Default to 1MiB alignment when possible (#618255)

2010-12-10 Thread Brian C. Lane
NOTE: This applies cleanly to parted-2.1 and parted-2.3 To better support 4k sector drives this changes the linux_get_optimum_alignment() function to prefer aligning partitions to DEFAULT_ALIGNMENT (1048576) if possible. This also modifies the alignment test to take this change into account. ---