[bug #40639] GNU Make with profiling information

2013-11-19 Thread Eddy Petrișor
URL: Summary: GNU Make with profiling information Project: make Submitted by: eddyp Submitted on: Tue 19 Nov 2013 21:31:16 GMT Severity: 3 - Normal Item Group: Enhancemen

[bug #40639] GNU Make with profiling information

2013-11-19 Thread Eddy Petrișor
Follow-up Comment #1, bug #40639 (project make): I have created a cleaned up rebased branch that contains only changes for the profiling feature so it can be easier to review. https://github.com/eddyp/make-profiler/tree/profile-rebase Please note this branch will be rebased. Use 'git pull --reb

Re: [bug #40639] GNU Make with profiling information

2013-11-20 Thread Eddy Petrișor
> On Tue Nov 19 22:29:22 2013, Reinier Post wrote: >> Follow-up Comment #1, bug #40639 (project make): >> >> I have created a cleaned up rebased branch that contains only changes for the >> profiling feature so it can be easier to review. >> >> https://github.com/eddyp/make-profiler/tree/profile-

[bug #40639] GNU Make with profiling information

2013-11-20 Thread Eddy Petrișor
Follow-up Comment #2, bug #40639 (project make): I have cleaned up the code to remove the warnings that were generated by the newly introduced code. I also reworked the rebase on the profile-rebase branch to contain cleaner patches and to separate the non-essential changes (e.g.: some whitespace

Re: [bug #40226] Weird failure on Windows with OUTPUT_SYNC_TARGET

2013-11-24 Thread Eddy Petrișor
Pe 24.11.2013 11:12, "Paul D. Smith" a scris: > I enhanced the option parsing in make to create a new type of option, that > takes a single string instead of a list of strings. If multiple instances of > that option are provided, each subsequent instance overwrites (instead of adds > to) the pre

[bug #40639] GNU Make with profiling information

2013-11-24 Thread Eddy Petrișor
Follow-up Comment #3, bug #40639 (project make): I rebased the patch on top of f5f5adb6, updated to use O and OS macros, and strlist type for the -P/--profile/--profile-format option parameter. The patch is attached. (file #29698) ___ Addi

Re: [bug #40226] Weird failure on Windows with OUTPUT_SYNC_TARGET

2013-11-24 Thread Eddy Petrișor
Pe 24.11.2013 18:41, "Paul Smith" a scris: > > On Sun, 2013-11-24 at 12:35 +0200, Eddy Petrișor wrote: > > Since you just worked on this, and the new type overwrites in case of > > repetition, does it make sense to overwrite instead of error? I think > > that fo

[bug #40639] GNU Make with profiling information

2013-11-26 Thread Eddy Petrișor
Follow-up Comment #5, bug #40639 (project make): Pe 25.11.2013 04:33, "Paul D. Smith" a scris: > > Follow-up Comment #4, bug #40639 (project make): > > Hi Eddy; thanks for your interest in improving GNU make! Hi Paul, You're welcome. > I think the idea of > providing more statistics for builds

Re: [bug #40639] GNU Make with profiling information

2013-11-26 Thread Eddy Petrișor
Pe 25.11.2013 11:09, "Reinier Post" a scris: > > > Can't this functionality be provided by a wrapper $SHELL? > > > Sure, it's an extra exec(), > > > but it will keep the make code base simpler. > > > > I'm not sure if I understand what you mean. Do you mean wrapping all target invokes in a $SHELL?

Re: [bug #40639] GNU Make with profiling information

2013-11-28 Thread Eddy Petrișor
that does > happen. I prefer JSON though because it's more readable and it's very > easy to parse. As I said before, I think that's the job of an external tool. > > On 27 November 2013 07:56, Eddy Petrișor wrote: > > > > Pe 25.11.2013 11:09, "Reinier Post&

[bug #40639] GNU Make with profiling information

2013-12-06 Thread Eddy Petrișor
Follow-up Comment #6, bug #40639 (project make): Here is a new version of the patch. Author: Eddy Petrișor Date: Tue Nov 19 05:14:40 2013 +0200 Now can choose profile format from predefined options Define 4 hard-coded profile printing formats which can be prefixed with an

[bug #40639] GNU Make with profiling information

2013-12-06 Thread Eddy Petrișor
Additional Item Attachment, bug #40639 (project make): File name: profile-predefs-ga4937bc8.patch Size:9 KB ___ Reply to this item at: ___ Message sent

[bug #40639] GNU Make with profiling information

2013-12-06 Thread Eddy Petrișor
Follow-up Comment #7, bug #40639 (project make): Please check https://savannah.gnu.org/bugs/download.php?file_id=29801 instead of file #29800 ___ Reply to this item at: _

Re: [bug #40639] GNU Make with profiling information

2013-12-15 Thread Eddy Petrișor
thout necessarily forcing me to rewrite my parser. Not sure what would you think could change in the output without informing the parser at all. Currently the prefix and the field separators are customisable. Maybe an example could help. > > Again, this is only an opinion - it car

Re: [bug #40639] GNU Make with profiling information

2013-12-18 Thread Eddy Petrișor
Pe 15.12.2013 18:07, "Paul Smith" a scris: > > On Sun, 2013-12-15 at 13:38 +, Tim Murphy wrote: > > I suppose I'm skirting around saying that I think gnu make needs an > > output format in the same way that valgrind has "--xml=yes". I'm not > > an XML fan really - JSON might be an alternative

Re: [bug #40639] GNU Make with profiling information

2014-01-08 Thread Eddy Petrișor
Paul, I would really appreciate feedback on this. If the problem is the licensing, don't worry about my rights, I will gladly give them to the FSF. Pe 18.12.2013 13:28, "Eddy Petrișor" a scris: > > > Pe 15.12.2013 18:07, "Paul Smith" a scris: > > >

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
Pe 11.01.2014 20:58, "Paul Smith" a scris: > > Sorry, I've been mostly away from my systems recently. > > > On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: > > > Thanks for clarifying this. Could you please confirm if the general > > directio

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
2014/1/12 Paul Smith : > On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: >> Could you please confirm if the general direction of the the is OK in >> the latest patch I sent? > > Conceptually it seems OK. I'm still not jazzed about having any more > than one

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
tart time. > I haven't looked at the patch - perhaps it's doing this? I tried this in local branch, but wasn't successful (code is not published for that attempt to avoid confusion around which code to review). > In any case, fixed/floating point seconds since 1970 is the nicest

Re: Converting make rules into other file formats

2017-10-15 Thread Eddy Petrișor
simple formatting of info is too much for make to do. Here is the bug report: https://savannah.gnu.org/bugs/?40639 Eddy Petrișor Pe 14 oct. 2017 10:47 PM, a scris: > SF Markus Elfring writes: > > > A Makefile is basically a human-readable text file with instructions > >

Re: Converting make rules into other file formats

2017-10-15 Thread Eddy Petrișor
e able to easily identify bottlenecks. The dependency graphing feature was also present in the branches I was planning to upstream since it allowed me to check if the dependencies in our build system were incorrect from a logical PoV (started with a sequential build

Re: Converting make rules into other file formats

2017-10-15 Thread Eddy Petrișor
Pe 15 oct. 2017 12:57 PM, "SF Markus Elfring" a scris: > Are the chances better to extend the tool “remake” then? … > Probably. Can it be that our software development resources are also too limited for mentioned tasks? I don't know. > My intention was to provide profiling information by

Re: use of math.h / libmath discouraged?

2018-07-25 Thread Eddy Petrișor
Eddy mie., 25 iul. 2018, 23:26 Brian Vandenberg a scris: > However, I'm not sure that this function is sufficiently generic to be >> > added as a built-in function. Can you provide use-cases for it? >> > > I suppose that depends on the definition of "sufficiently generic". The > two definition

Re: use of math.h / libmath discouraged?

2018-07-27 Thread Eddy Petrișor
joi, 26 iul. 2018, 19:42 Brian Vandenberg a scris: > Wouldn't profiling information help? >> See details and link to code with 3.81 that does this at: >> > > Yes, it would. I was unaware of that issue. > > It looks as though that feature never made it in [unfortunately]. If it > were added, was

Re: Compacting link-rules

2018-10-18 Thread Eddy Petrișor
joi, 18 oct. 2018, 18:56 Paul Smith a scris: > On Thu, 2018-10-18 at 17:40 +0200, Gisle Vanem wrote: > >bin/%.exe: $($(@F)_OBJ) $(LIBS) > >$(call link_EXE, $@, $^) > > This cannot work because automatic variables like $@, etc. are only > valid _inside a recipe_. They are not set

Re: Compacting link-rules

2018-10-21 Thread Eddy Petrișor
Will do. Eddy vin., 19 oct. 2018, 16:52 Paul Smith a scris: > On Fri, 2018-10-19 at 09:26 +0300, Eddy Petrișor wrote: > > I have a similar issue, but in my case I used explicit pattern rules, > > vpath and added compiler generated .d files to make sure the object > > fil