[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread David Boyce
Follow-up Comment #7, bug #63686 (project make): It almost sounds like you're making the case against your own proposal now :-). Given what you say, what's the reasoning for doing this as a --warn... flag vs a special target? I trust your judgment but I don't quite understand it. Parenthetically,

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread Paul D. Smith
Follow-up Comment #8, bug #63686 (project make): I'm just trying to be clear about what is available, and the tradeoffs. Maybe some of these are not interesting to consider. There is an argument to be made that requiring every individual makefile to include its own .WARNINGS: special target (or

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread Paul D. Smith
Follow-up Comment #9, bug #63686 (project make): One other thing: obviously a special target can't be in effect until it appears in the makefile, unlike a command line option which is always in effect. That means that if you didn't put that special target right at the top of a given makefile, you

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread Dmitry Goncharov
Follow-up Comment #11, bug #63686 (project make): Paul, if you decide to do the special target, do you intend to let that special target have prerequisites, e.g. targets for which the feature is enabled? ___ Reply to this item at:

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread Paul D. Smith
Follow-up Comment #12, bug #63686 (project make): > Paul, if you decide to do the special target, do you intend to let that special target have prerequisites, e.g. targets for which the feature is enabled? No, the prerequisites of the special target are the warning control options: .WARNINGS: err

Pattern rules and '/'

2023-02-27 Thread Frank Heckenbach
GNU Make 4.4.1 According to the manual, in pattern rules, "the '%' matches any nonempty substring". Accordingly, I'd have expected this Makefile: all: foo-bar/baz foo-%:; echo "$*" to echo "bar/baz". But instead, I get: make: *** No rule to make target 'foo-bar/baz', needed by 'all'. Sto

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread David Boyce
Follow-up Comment #10, bug #63686 (project make): Again, I'm generally ok with your implementation. No big objections, but in an attempt to carry these discussions to closure: > MAKEFLAGS are by definition passed to recursive makes ... My $dayjob builds, among other things, a Linux kernel module

[bug #63686] implement a flag to promote make warnings to fatal errors

2023-02-27 Thread David Boyce
Follow-up Comment #13, bug #63686 (project make): Hmm, this is a dizzying array of choices! Since 4.4.1 is gone and this feature will only be in the next full release which is presumably far off still, it seems there's no rush to decide. Maybe push it as is to let people play with it in beta form?