[bug #57152] Fix WINDOWS32 gcc build

Follow-up Comment #2, bug #57152 (project make): Paul, please note that mingw.org's MinGW does provide the 'd_type' member of struct dirent, unlike MinGW64 which doesn't. The config.h template is correct for mingw.org, and the change should not be unconditional, it should be conditioned with some

[bug #57152] Fix WINDOWS32 gcc build

Follow-up Comment #3, bug #57152 (project make): Oh that's good to know. I used __MINGW32__ which I guess is not right. According to my research I guess I should use __MINGW64__ instead. ___ Reply to this item at:

Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*

On Sat, 2019-11-23 at 12:22 +0100, Jouke Witteveen wrote: > Is there anything I can do to further review and/or acceptance of this > patch I sent last month? I applied your changes although updates were needed. For the future, please note that (a) changes should contain updates to the regression

Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*

On Wed, Dec 18, 2019 at 3:11 PM Paul Smith wrote: > I applied your changes although updates were needed. > > For the future, please note that (a) changes should contain updates to the > regression tests to show the error and ensure the fix works, (b) commit > messages need to be formatted properly

Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*

On Wed, 2019-12-18 at 16:02 +0100, Jouke Witteveen wrote: > Your se_implicit test case got left out of your commit. I guess this > was unintentional. I'm not sure what you mean? It's there...? > Presumably, the test case was based on [SV 54161]. The bug can now be > closed. Yes, will do that la

Re: [PATCH v2 2/3] [SV 54161] Fix second expansion of $*

On Wed, Dec 18, 2019 at 4:19 PM Paul Smith wrote: > > On Wed, 2019-12-18 at 16:02 +0100, Jouke Witteveen wrote: > > Your se_implicit test case got left out of your commit. I guess this > > was unintentional. > > I'm not sure what you mean? It's there...? My mistake. I must have done something wr

[bug #57152] Fix WINDOWS32 gcc build

Follow-up Comment #4, bug #57152 (project make): I don't have MinGW64 installed to try that, but if you tried it and it worked, then I guess it's fine. The problem with __MINGW64__ is that AFAIK it isn't defined by the compiler, it is in some header file. So if config.h is included before any Mi

[bug #54161] Expansion of $$* is incorrect

Update of bug #54161 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #57152] Fix WINDOWS32 gcc build

Follow-up Comment #5, bug #57152 (project make): I don't have access to any Windows systems with any version of either cygwin or mingw installed (well, I have Git for Windows installed and it provides some aspects of mingw I believe), nor clang or GCC for windows: all I can test is the simple nati