[bug #40227] Various fixes for MSVC build of 4.0

2013-10-11 Thread Mike Hommey
Follow-up Comment #1, bug #40227 (project make): The issue addressed by the second patch also manifests itself when using $(error) and $(warning), which don't print a message most of the time. ___ Reply to this item at:

[bug #40241] CreateProcess failure with unixy paths

2013-10-11 Thread Mike Hommey
URL: Summary: CreateProcess failure with unixy paths Project: make Submitted by: glandium Submitted on: Fri 11 Oct 2013 11:54:37 AM GMT Severity: 3 - Normal Item Group: E

Re: [bug #40225] Deterministic output ordering

2013-10-11 Thread Josh Triplett
On Fri, Oct 11, 2013 at 07:56:06AM +0100, Tim Murphy wrote: > >> The idea of diffing 2 builds is truly a cool one - especially when > >> they're huge - but I'd rather it was done according to keys or other > >> factors e.g. target name. > >> I'd like to compare the time it took to build various tar

Re: [bug #40225] Deterministic output ordering

2013-10-11 Thread Edward Welbourne
>> Then commit all the log files to git and use git show to find out which >> of them have changed since the last build. (I trust you can all work >> out the equivalent steps for *your* preferred SCM system.) This only >> has to happen on the server that builds from clean on a regular basis. > >

[bug #33034] "Makefile:23: *** mixed implicit and normal rules. Stop." for Linux kernel out of source builds

2013-10-11 Thread David Boyce
Follow-up Comment #11, bug #33034 (project make): Frank, I agree with some of your points but there was a bit of cherrypicking involved in the quoting: > ... really, what's the chance a trivial one-line change to the top-level makefile will actually break your driver? I'm not sure you realize t

[bug #33034] "Makefile:23: *** mixed implicit and normal rules. Stop." for Linux kernel out of source builds

2013-10-11 Thread David Boyce
Follow-up Comment #12, bug #33034 (project make): I'm uploading a patch that adds an --allow-mixed-rules option which converts the fatal error to a warning. This is the only testing it's been subjected to: % cat Makefile all %.o: @echo Making "$@" % make-4.0 Makefile:1: *** mixed implici

[bug #33034] "Makefile:23: *** mixed implicit and normal rules. Stop." for Linux kernel out of source builds

2013-10-11 Thread Josh Triplett
Follow-up Comment #13, bug #33034 (project make): You should check if "make foo.o" works, and if dependencies on either "all" or "foo.o" or both work as expected. I'll give the patch a try with an older Linux kernel and see if it fixes the build issue. I'm somewhat skeptical that removing the fa

[bug #33034] "Makefile:23: *** mixed implicit and normal rules. Stop." for Linux kernel out of source builds

2013-10-11 Thread David Boyce
Follow-up Comment #14, bug #33034 (project make): Yes, I realize it's a bit of a wing and a prayer but from the git log it looks like this fix got into the same commit as a rewrite of major sections of read.c. Without reading and thinking through all of it, I figured there was a chance that adding