Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Sam Ravnborg
On Tue, Jun 19, 2007 at 08:50:32PM +0200, Stephan Beal wrote: > Hi, Makers! > > i just discovered a Make behaviour which really surprises me. While that > in itself is nothing new ;), this one certainly violates the principal > of least astonishment: > > When a $(warning) or $(error) is inside

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Paul Smith
On Tue, 2007-06-19 at 20:50 +0200, Stephan Beal wrote: > When a $(warning) or $(error) is inside a 'define', it is evaluated > even if it is part of a comment. Others have responded with all the info but I'm not sure everyone understood it. There are two factors at work here. First, note that ma

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Stephan Beal
On Wednesday 20 June 2007, Philip Guenther wrote: > On 6/19/07, Stephan Beal <[EMAIL PROTECTED]> wrote: > Okay, so you've defined a variable, 'bogo', whose value consists of > two lines, the first of which has a '#' as its first non-whitespace > character. It isn't a comment at that point, it's ju

Re: bug? $(warning)/$(error) evaluated from inside a comment in a 'define'?

2007-06-20 Thread Stephan Beal
On Wednesday 20 June 2007, Paul Smith wrote: > the variable being defined. In fact nothing is parsed inside a > define. I'm not sure, from your message, if this is what you feel is > the surprising behavior; Right - that's what surprised me. i assumed that comments were skipped during the init

Problems with gmake and pipefail. make doesn't give up.

2007-06-20 Thread Erwin Waterlander
Hi, I have a problem that gnu make doesn't give up after an error in a command in a pipe. I have attached a simple example. I run a command (ls) and the output is piped to command 'tee' to send the output of 'ls' to a file and stdout. Normally the shell returns the exit code of the last comm

RE: Problems with gmake and pipefail. make doesn't give up.

2007-06-20 Thread Erwin Waterlander
Hi, I compiled bash 3.2 locally. When I set SHELL=/home/waterlan/src/bash-3.2/bash -e -o pipefail everything works as expected. So the problem must be in the AT&T sh. -- Erwin Waterlander From: Erwin Waterlander Sent: Wed 6/20/2007 16:46 To: bug-make@gnu.or

RE: Problems with gmake and pipefail. make doesn't give up.

2007-06-20 Thread Paul Smith
On Wed, 2007-06-20 at 17:32 +0200, Erwin Waterlander wrote: > I compiled bash 3.2 locally. When I set > SHELL=/home/waterlan/src/bash-3.2/bash -e -o pipefail everything > works as expected. So the problem must be in the AT&T sh. As far as I know, ksh doesn't support pipefail. If so, it's not a