Re: [PATCH 2/2] compare function

2020-06-09 Thread Edward Welbourne
On Tue, Jun 9, 2020 at 10:53 AM Edward Welbourne wrote: >> I note that your implementation only supports numeric lhs and rhs. >> Might it be worth falling back, if either of them isn't numeric, to >> doing a strcmp() comparison instead ? Possibly after stripping >> leading space from each. There

Re: [PATCH 2/2] compare function

2020-06-09 Thread Jouke Witteveen
On Tue, Jun 9, 2020 at 10:53 AM Edward Welbourne wrote: > > Jouke Witteveen (8 June 2020 22:20) > > It differs from his original proposal in that it behaves differently > > when given 4 or 5 arguments. In short, it's signature is > > > > $(compare lhs,rhs,less-than[,greater-or-equal]) > > $(comp

Re: [PATCH 2/2] compare function

2020-06-09 Thread Edward Welbourne
Jouke Witteveen (8 June 2020 22:20) > This is an implementation of a $(compare) function as proposed by > Edward Welbourne. Yay ;^> Looks promising in general. As ever, review consists mostly of criticism, so let me just say I approve of the general plan, before I start in on that ... > It differ

[PATCH 2/2] compare function

2020-06-08 Thread Jouke Witteveen
This is an implementation of a $(compare) function as proposed by Edward Welbourne. It differs from his original proposal in that it behaves differently when given 4 or 5 arguments. In short, it's signature is $(compare lhs,rhs,less-than[,greater-or-equal]) $(compare lhs,rhs,less-than,equal,gr