EAGAIN in "read jobs pipe"

2007-01-08 Thread Ken Takusagawa
For reasons I haven't completely triaged yet, I've been having my parallel makes die with "read jobs pipe: Resource temporarily unavailable. Stop." I hacked the function new_job in job.c such that if errno==EAGAIN, then we sleep(1) and loop again, and my problem went away. (Essentially adding EA

jobserver_fds->list buffer overflow

2007-01-08 Thread Ken Takusagawa
In main.c we have jobserver_fds->list[0] = xmalloc ((sizeof ("1024")*2)+1); sprintf (jobserver_fds->list[0], "%d,%d", job_fds[0], job_fds[1]); Shouldn't xmalloc get a "+2" instead of "+1"? 1 for the comma, and one for the null terminator? --ken