Mark more symbols as static

2021-03-08 Thread Yuri Gribov
Hi all, It seems few more symbols in make can be marked as static: default_load_average (src/main.o) directory_before_chdir (src/main.o) job_counter (src/job.o) make_sync (src/main.o) output_sync_option (src/main.o) sync_mutex (src/main.o) I do not have copyright assignment so am not s

[bug #60077] Deterministic $@ for grouped targets patch

2021-03-08 Thread Todd Lowe
Follow-up Comment #2, bug #60077 (project make): I admit I wasn't too thrilled about making $@ behave differently between explicit and pattern rules, but I definitely did not want to change the long standing pattern rule behaviour and didn't find the grouped-target $@ useful. I had proposed $! fo

[bug #60077] Deterministic $@ for grouped targets patch

2021-03-08 Thread Paul D. Smith
Follow-up Comment #1, bug #60077 (project make): I'm not too jazzed about the idea of $@ working differently for explicit vs. pattern rule grouped targets. I agree that the "instigating target" may not be so useful, but if we change $@ to be a deterministic target then there's NO way to obtain th

[bug #60188] Explicit file built by an implicit rule is not intermediate.

2021-03-08 Thread Paul D. Smith
Follow-up Comment #2, bug #60188 (project make): I agree this is a bug. Thanks Dmitry I'll look at these fixes. Now that your paperwork is (finally) complete I owe you a lot of patch reviews / applications. ___ Reply to this item at: <