Re: diversion failure [was: snapshot in preparation for m4 1.4.12]

2008-09-02 Thread Bruno Haible
Eric Blake wrote: > In looking at this further, it looks like line 4179 of vasnprintf.c should > _not_ count precision as a prefix if prec_ourselves is nonzero. Yes. Now that you say it, it's obvious that the code in line 4179 should be in sync with the code in line 4077. > Without the patch to v

Re: diversion failure [was: snapshot in preparation for m4 1.4.12]

2008-09-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/2/2008 4:50 AM: >> >> OK to apply? Are there other files in lib or tests that need matching >> modifications? > > Yes, please apply. 4 test files should be modified in sync: > > $ grep -rl 4000d tests/ > tests/test-snp

Re: next snapshot in preparation for m4 1.4.12

2008-09-02 Thread Tom G. Christensen
On Mon, Sep 01, 2008 at 02:48:20PM -0600, Eric Blake wrote: > Shoot. I got the logic backwards. We want the test to exit with non-zero > status if c_stack_action fails (returns non-zero), or if recurse returns > (which should be impossible). The conditional should be written with ||, > not &&.

Re: next snapshot in preparation for m4 1.4.12

2008-09-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Tom G. Christensen on 9/2/2008 9:28 AM: >> So, with my typo fixed, can you once again try those debugging steps, to >> see if the breakpoint in overflow_handler trips? >> > It does not. Which means I think we have isolated the bug to the

Re: next snapshot in preparation for m4 1.4.12

2008-09-02 Thread Tom G. Christensen
On Tue, Sep 02, 2008 at 01:20:43PM -0600, Eric Blake wrote: > I wonder if switching to libsigsegv's version will solve it. In the > meantime, I would be curious to see the disassembly of recurse, to see if > anything obvious appears as to why p==0 rather than a valid stack address > before the fin