Re: undiagnosed integer overflow in parsing frozen files

2008-05-09 Thread Eric Blake
Eric Blake byu.net> writes: > According to Jim Meyering on 5/8/2008 1:10 PM: > | > | However, given too long a string of digits, "Number" overflows. > > Accidental, but not unnoticed, and hopefully not severe. > But now that you mention it, I'll > probably tighten up the check Like this. >Fro

Re: undiagnosed integer overflow in parsing frozen files

2008-05-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 5/8/2008 1:10 PM: | | However, given too long a string of digits, "Number" overflows. | Considering the rigorous parsing elsewhere in that file, I think | this must be accidental. Accidental, but not unnoticed, and hopefu

undiagnosed integer overflow in parsing frozen files

2008-05-08 Thread Jim Meyering
Hi, I noticed that freeze.c parses integers like this: #define GET_NUMBER(Number) \ do\ { \ (Number) = 0;