Re: test failure on FreeBSD 12.0

2020-05-03 Thread Paul Eggert
On 5/3/20 2:58 AM, Bruno Haible wrote: > Unfortunately, this patch does not fix the test failure on FreeBSD 12.0. There are some other places where the m4 code assumes wrapv arithmetic (or worse, where it messes up in other ways on integer overflow). Attached is a patch that fixes some of

Re: test failure on FreeBSD 12.0

2020-05-03 Thread Bruno Haible
n the FreeBSD C compiler, it's in m4. OK, let's clean up the incorrect assumptions about signed integer arithmetic first. Here's a patch that does this, in the caller of the 'ntoa' function. I don't see incorrect assumptions in the code of 'ntoa' itself. Unfortu

Re: test failure on FreeBSD 12.0

2020-05-03 Thread Paul Eggert
On 5/2/20 6:06 PM, Bruno Haible wrote: > The attached patch (for the 'branch-1.4' branch) fixes the issue. I think the actual bug lies elsewhere: m4 is written as if int32_t arithmetic wraps around silently, but that's not what C does. If I'm right, the bug is not in the FreeBSD C compiler, it's i

test failure on FreeBSD 12.0

2020-05-02 Thread Bruno Haible
Hi, On FreeBSD 12.0/x86, the newest release m4-1.4.18 and the newest snapshot from https://gitlab.com/gnu-m4/ci-distcheck/ both exhibit a "make check" failure: Checking ../../checks/189.eval @ ../doc/m4.texi:6405: Origin of test ../../checks/189.eval: stdout mismatch --- m4-tmp.17036/m4-xout