Re: [tablatures] tremolos in tablature

2010-08-28 Thread Carl Sorensen
On 8/28/10 9:11 AM, "Neil Puttock" wrote: > On 28 August 2010 14:46, Marc Hohl wrote: > >> Just a little ping - is the patch ok, or should I load it to Rietveld? > > Looks OK apart from this: > > + %% NOTE: in lily/stem-tremolo.cc, we have length-fraction = 1, > + %% and the tablature st

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Neil Puttock
On 28 August 2010 16:17, Carl Sorensen wrote: > Why not use 1/staff-space?  This would adjust things regardless of how > staff-space was tweaked, wouldn't it? Yes. A simple helper function using ly:staff-symbol-staff-space would suffice (apart from 'beam-width, which needs a wrapper around ly:s

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Neil Puttock
On 28 August 2010 14:46, Marc Hohl wrote: > Just a little ping - is the patch ok, or should I load it to Rietveld? Looks OK apart from this: + %% NOTE: in lily/stem-tremolo.cc, we have length-fraction = 1, + %% and the tablature staff space is scaled by 1.5, so we use 1/1.5=0.67 These commen

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Marc Hohl
Marc Hohl schrieb: [...] Ok, so here is a patch. I had to adjust length-fraction as well, and it is strange that this is somewhat hard-coded in lily/stem-tremolo.cc, but since the default is 1, it probably doesn't matter. Marc Just a little ping - is the patch ok, or should I load it to Rietv

Re: [tablatures] tremolos in tablature

2010-08-24 Thread Marc Hohl
Carl Sorensen schrieb: On 8/23/10 3:28 PM, "Marc Hohl" wrote: Carl Sorensen schrieb: [...] It seems that we should use 0.48 times the *actual* staff space, rather than the default staff space. Um, after reading your answer twice - it should be the other w

Re: tremolos in tablature

2010-08-23 Thread Dmytro O. Redchuk
On Mon 23 Aug 2010, 10:29 Patrick Schmidt wrote: > Hi all, > > in the following example misplaced tremolos appear in tablature > without \tabFullNotation. With \tabFullNotation the symbols are > placed correctly but IMO in both cases the tremolo symbols are too > massive in tablature (see attached

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Carl Sorensen
On 8/23/10 3:28 PM, "Marc Hohl" wrote: > Carl Sorensen schrieb: >> [...] >>> >> It seems that we should use 0.48 times the *actual* staff space, rather than >> the default staff space. > Um, after reading your answer twice - it should be the other way round, > isn't it? Oops, yes, of cour

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Marc Hohl
Carl Sorensen schrieb: [...] The #'beam-thickness of the tremolo beams is defined in scm/define-grobs.scm as .48 * staff space. In ly/engraver-init.ly we have the staff space spread to 1.5 * staff space, so it would be optimal to define the #'beam-thickness in TabStaff being 0.48/1.5=0.32 to ens

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Marc Hohl
Carl Sorensen schrieb: [...] It seems that we should use 0.48 times the *actual* staff space, rather than the default staff space. Um, after reading your answer twice - it should be the other way round, isn't it? The *actual* staff space within a TabStaff is 1.5 * default staff space, a

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Marc Hohl
Carl Sorensen schrieb: On 8/23/10 1:26 PM, "Marc Hohl" wrote: Patrick Schmidt schrieb: Hi all, Hi Patrick, yes, of course. I didn't use tremolos very often while playing around with the new tablature appearance which yielded to scm/tablature.scm, so I overlooked this.

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Marc Hohl
Patrick Schmidt schrieb: Hi all, in the following example misplaced tremolos appear in tablature without \tabFullNotation. With \tabFullNotation the symbols are placed correctly but IMO in both cases the tremolo symbols are too massive in tablature (see attached pngs). \version "2.13.30" m

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Carl Sorensen
On 8/23/10 1:26 PM, "Marc Hohl" wrote: > Patrick Schmidt schrieb: >> Hi all, > Hi Patrick, > > yes, of course. I didn't use tremolos very often while playing around with > the new tablature appearance which yielded to scm/tablature.scm, so > I overlooked this. >> Workaround(s): >> 1) Use >>

Re: [tablatures] tremolos in tablature

2010-08-23 Thread Patrick Schmidt
Am 23.08.2010 um 21:26 schrieb Marc Hohl: Patrick Schmidt schrieb: Hi all, in the following example misplaced tremolos appear in tablature without \tabFullNotation. With \tabFullNotation the symbols are placed correctly but IMO in both cases the tremolo symbols are too massive in tablat

Re: tremolos in tablature

2010-08-23 Thread Dmytro O. Redchuk
On Mon 23 Aug 2010, 10:29 Patrick Schmidt wrote: > Hi all, Hi! (Un)fortunately, i know nothing about tablatures, so let's wait for some quite possible feedback. Tomorrow, if nothing happens (this is quite possible, too) i'll add this to tracker. Thank you! (below is overquote, nothing more) >

tremolos in tablature

2010-08-23 Thread Patrick Schmidt
Hi all, in the following example misplaced tremolos appear in tablature without \tabFullNotation. With \tabFullNotation the symbols are placed correctly but IMO in both cases the tremolo symbols are too massive in tablature (see attached pngs). \version "2.13.30" music = { 4:16 \stem