Hi Neil,
Here's the amended patch.
Cheers,
Ian
On 22/02/10 22:17, n.putt...@gmail.com wrote:
On 2010/02/22 18:27:19, Ian Hulin wrote:
Sorry if this sounds a bit jobsworth but I'd rather this patch went
out
the door as is and I'll look at your comment as part of work on a new
tracker.
Fa
http://codereview.appspot.com/194095/diff/2001/1003
File lily/tuplet-bracket.cc (right):
http://codereview.appspot.com/194095/diff/2001/1003#newcode4
lily/tuplet-bracket.cc:4: Copyright (C) 1997--2009 Jan Nieuwenhuizen
On 2010/02/22 22:18:10, Neil Puttock wrote:
rebase again?
Done.
http://c
Sorry, here they are:
http://codereview.appspot.com/194095/diff/2001/1003
File lily/tuplet-bracket.cc (right):
http://codereview.appspot.com/194095/diff/2001/1003#newcode4
lily/tuplet-bracket.cc:4: Copyright (C) 1997--2009 Jan Nieuwenhuizen
rebase again?
http://codereview.appspot.com/194095/d
On 2010/02/22 18:27:19, Ian Hulin wrote:
Sorry if this sounds a bit jobsworth but I'd rather this patch went
out
the door as is and I'll look at your comment as part of work on a new
tracker.
Fair enough. Send me the patch when you've sorted the nitpicks below.
Cheers,
Neil
http://coderev
On 20/02/10 17:27, n.putt...@gmail.com wrote:
Hi Ian,
Looks OK, though don't you think it would be better to increase the size
of the bracket if it's too small?
We--ll, yes, but that's not what this bug report is about. As it's
something you've picked up during the review it's strictly speaki
Reviewers: Neil Puttock,
Message:
Hi Neil,
I've fixed the comment. Please push this patch (I've rebased it to
branch from latest origin/master).
Cheers,
Ian
http://codereview.appspot.com/194095/diff/1/2
File lily/tuplet-bracket.cc (right):
http://codereview.appspot.com/194095/diff/1/2#newco
Hi Ian,
Looks OK, though don't you think it would be better to increase the size
of the bracket if it's too small?
Cheers,
Neil
http://codereview.appspot.com/194095/diff/1/2
File lily/tuplet-bracket.cc (right):
http://codereview.appspot.com/194095/diff/1/2#newcode286
lily/tuplet-bracket.cc:28
