Re: Possible regression with box-markup/rounded-box-markup

2018-04-15 Thread Thomas Morley
2018-04-16 1:03 GMT+02:00 Torsten Hämmerle : > I've now started #5307:Skyline Refinements (Rounded Boxes and Rotated > Ellipses) > > It also takes care of rotation issues (both boxes and ellipses) and even > produces skylines with rounded cor

Re: Possible regression with box-markup/rounded-box-markup

2018-04-15 Thread Torsten Hämmerle
I've now started #5307:Skyline Refinements (Rounded Boxes and Rotated Ellipses) It also takes care of rotation issues (both boxes and ellipses) and even produces skylines with rounded corners. Special case: no rotation, small corner radiu

Re: Possible regression with box-markup/rounded-box-markup

2018-03-29 Thread Torsten Hämmerle
Hi Harm, The good news: The correction is just changing the skyline cornering points in make_round_filled_box_boxes, nothing else. The bad news: make_round_filled_box_boxes is very much in use (e.g. for ledger-lines) and so changing/correcting these skylines will have an effect on basically all t

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Thomas Morley
2018-03-28 22:43 GMT+02:00 Torsten Hämmerle : > Yes, and your terrible example looks like > > > > in LilyDev with my slight corrections applied. > Seems OK to me. Indeed, the image looks fine. I really hope there's no impa

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Torsten Hämmerle
Yes, and your terrible example looks like in LilyDev with my slight corrections applied. Seems OK to me. Cheerio, Torsten -- Sent from: http://lilypond.1069038.n5.nabble.com/Bugs-f58488.html _

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Thomas Morley
Hi again, 2018-03-28 21:09 GMT+02:00 Torsten Hämmerle : > In any case, the additional space around the \rounded-box is proportional to > the corner-radius. > If you set corner-radius to 0, there's no gap anymore. As the corner-radius > increases, so does the gap. Setting corner-radius zero gives

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Torsten Hämmerle
Hi Harm, I think I've got it... You are perfectly right, there is a slight inconsistency in lily/stencil-integral.cc C++ code. (I just have to get it completely right, still experimenting a bit...): The C++ code obviously confuses line thickness and blot diameter and and "corrects" (i.e. enlarge

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Thomas Morley
2018-03-28 21:09 GMT+02:00 Torsten Hämmerle : > In any case, the additional space around the \rounded-box is proportional to > the corner-radius. > If you set corner-radius to 0, there's no gap anymore. As the corner-radius > increases, so does the gap. > > I think it's the rounded-box-stencil's di

Re: Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Torsten Hämmerle
In any case, the additional space around the \rounded-box is proportional to the corner-radius. If you set corner-radius to 0, there's no gap anymore. As the corner-radius increases, so does the gap. I think it's the rounded-box-stencil's dimensions: when explicitly setting them to xext/yext, ever

Possible regression with box-markup/rounded-box-markup

2018-03-28 Thread Thomas Morley
The gap from a box-markup and a rounded-box-markup to the Staff differs for unknown reason. \version "2.18.2" %% up to current master { c''^\markup \box 1 c''^\markup \rounded-box 1 c''_\markup \box 1 c''_\markup \rounded-box 1 } 2.16.2 and before return same gap. Regresion? Attached i