Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-22 Thread lilypond
Comment #23 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Issue 1559 has been merged into this issue. ___ bug-lilypond mailing list bug-lilypon

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-22 Thread lilypond
Comment #22 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Issue 1788 has been merged into this issue. ___ bug-lilypond mailing list bug-lilypon

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-20 Thread lilypond
Updates: Status: Verified Comment #21 on issue 2376 by elu...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 (No comment was entered for this change.) ___ b

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-11 Thread lilypond
Updates: Status: Fixed Owner: d...@gnu.org Labels: -Patch-push Fixed_2_15_34 Comment #20 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Pushed as b0a0b0da364a2379e3a2

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-11 Thread lilypond
Updates: Labels: -Patch-countdown Patch-push Comment #19 on issue 2376 by colinpkc...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Counted down to 20120311, please push.

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-07 Thread lilypond
Updates: Labels: Patch-review Comment #17 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c17 Patchy the autobot says: LGTM. ___ bug-lily

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-07 Thread lilypond
Updates: Labels: Patch-new Comment #16 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c16 Issue 2376: Automatic footnotes on \null markups causes unexpected results The page layout

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-06 Thread lilypond
Comment #15 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Issue 2369 has been merged into this issue. ___ bug-lilypond mailing list bug-lilypon

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-06 Thread lilypond
Updates: Labels: Patch-review Comment #14 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c14 Patchy the autobot says: LGTM. 3 lines add whitespace errors, but I trust you will fix

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-06 Thread lilypond
Updates: Labels: Patch-new Comment #13 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c13 Issue 2376: Automatic footnotes on \null markups causes unexpected results The page layout

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-06 Thread lilypond
Comment #12 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 There is little enough reason to diverge, actually. page-layout-problem.cc is a total mess indiscriminately passing around point

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Updates: Owner: mts...@gmail.com Labels: -Patch-review Patch-needs_work Comment #11 on issue 2376 by colinpkc...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 There seems to be quite divergent

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #10 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 To quote from stencil.hh: * Do not create Stencil objects on the heap. That includes passing around Stencil* which are pro

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #9 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 I've taken a look at the Scheme functions for stencils, and they basically _all_ create copies whenever they operate on a stencil.

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Updates: Labels: Patch-review Comment #8 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c8 Patchy the autobot says: LGTM. But I don't like all that performance hit just because fo

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #7 on issue 2376 by mts...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 « There will be lots of situations where one will want to pass a typed equivalent of "nothing", and it is a nuisance if "nothi

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #6 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 A whole note stencil has properties. A non-empty list has elements, a non-empty string has characters. Those can be changed and

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #5 on issue 2376 by mts...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 This code matches up with how stencils are represented internally and how the code uses then in general. One could, for examp

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #4 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 I have no clue how stencils are represented internally. And while one may have mixed feelings about point-stencil, something like

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #3 on issue 2376 by mts...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 You're right that it's invasive, but that doesn't bother me, as I think the change is more coherent w/ how LilyPond handles st

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Comment #2 on issue 2376 by d...@gnu.org: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Too invasive for my taste. There is nothing wrong with having a single null stencil and/or empty stencil. What is wrong is when

Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-04 Thread lilypond
Updates: Labels: Patch-new Comment #1 on issue 2376 by mts...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376#c1 Makes empty stencil and point stencil functions http://codereview.appspot.com/5726053 _

Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results

2012-03-03 Thread lilypond
Status: Accepted Owner: Labels: Type-Defect New issue 2376 by pkx1...@gmail.com: Automatic footnotes on \null markups causes unexpected results http://code.google.com/p/lilypond/issues/detail?id=2376 Nicolas Sceaux writes: Hi, Using today's git LilyPond, the following snippet gives we