Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-03-22 Thread lilypond
Updates: Labels: -Patch-countdown Patch-needs_work Comment #12 on issue 2310 by gra...@percival-music.ca: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310 We have some concerns about the .gitignore; the patch as it stands is not

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-03-21 Thread lilypond
Updates: Labels: Patch-review Comment #10 on issue 2310 by d...@gnu.org: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310#c10 Patchy the autobot says: LGTM. ___ bug-lilypond mailing li

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-03-21 Thread lilypond
Comment #8 on issue 2310 by milimet...@gmail.com: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310#c8 Corrected style of comments http://codereview.appspot.com/5862052 ___ bug-lilypond mailin

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-02-16 Thread lilypond
Updates: Labels: -Patch-push Patch-needs_work Comment #7 on issue 2310 by janek.li...@gmail.com: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310 Han-Wen, Keith and Joe's comments need to be addressed. __

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-02-14 Thread lilypond
Updates: Labels: -Patch-countdown Patch-push Comment #5 on issue 2310 by colinpkc...@gmail.com: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310 Counted down to 20120214, please push.

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-02-12 Thread lilypond
Updates: Labels: Patch-review Comment #3 on issue 2310 by d...@gnu.org: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310#c3 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list

Re: Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-02-11 Thread lilypond
Comment #2 on issue 2310 by janek.li...@gmail.com: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310#c2 some comments and complaints on the code direction.hh: added a #define loop for_UP_and_DOWN() for iterating through: {UP, DOWN} mino

Issue 2310 in lilypond: Patch: some comments and complaints on the code

2012-02-10 Thread lilypond
Status: New Owner: Labels: Type-Enhancement Patch-new New issue 2310 by janek.li...@gmail.com: Patch: some comments and complaints on the code http://code.google.com/p/lilypond/issues/detail?id=2310 some comments and complaints on the code direction.hh: added a #define loop for_UP_and_D