Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2012-01-08 Thread lilypond
Updates: Status: Verified Mergedinto: Comment #57 on issue 2057 by colinpkc...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Verified with T2130 using 2.15.24 ___ bug-lilypond

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-20 Thread lilypond
Updates: Status: Duplicate Labels: -Patch-new Mergedinto: 2130 Comment #56 on issue 2057 by gra...@percival-music.ca: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 continued in issue 2130. sorry. Don't add any patch tags t

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-19 Thread lilypond
Updates: Status: Started Owner: k-ohara5...@oco.net Labels: -Patch-push Patch-new Comment #55 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I've put this back to Started. The code base

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-16 Thread lilypond
Updates: Status: Fixed Comment #54 on issue 2057 by colingh...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I've put this back to Fixed. Phil Holmes pointed out that this one is a bug fix and so should not simply be marked Ver

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-16 Thread lilypond
Updates: Status: Verified Comment #53 on issue 2057 by colingh...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Verified that this has been committed to the repo. ___ bug-lilypond mai

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-16 Thread lilypond
Comment #52 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Rectification - the SHA1 ID is f417a6007e951fda4f1fb5fd3da0ecd1d25cec2f Cheers, MS ___ bug-lilypond mailing

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-16 Thread lilypond
Updates: Status: Fixed Comment #51 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Pushed to staging as 5543eb5b0378bc726684a686b799e4ff4dc5f4cc. ___ bug-lilypon

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-15 Thread lilypond
Updates: Labels: -Patch-countdown Patch-push Comment #50 on issue 2057 by colinpkc...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Counted down to 20111215 ___ bug-lilypond mailing l

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-12 Thread lilypond
Comment #49 on issue 2057 by gra...@percival-music.ca: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 This patch does a lot of stuff, and has had a lot of discussion. I would feel better if the final version of the patch went through another co

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-11 Thread lilypond
Comment #48 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Hey - sorry to be a patch push nag, but I'd like to get my queue cleared out. This patch hasn't changed since December 6th save the occasional rebase a

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-10 Thread lilypond
Updates: Labels: Patch-review Comment #46 on issue 2057 by lilypond...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c46 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-10 Thread lilypond
Updates: Labels: Patch-new Comment #45 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c45 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-08 Thread lilypond
Updates: Labels: Patch-review Comment #43 on issue 2057 by lilypond...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c43 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-08 Thread lilypond
Comment #42 on issue 2057 by gra...@percival-music.ca: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 There are no plans for any more 2.14 releases. The 2.16 release will happen when the current Critical releases reaches 0. ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-08 Thread lilypond
Comment #41 on issue 2057 by prze...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Great. Sorry for constant complaints. :) I forgot to add one more thing. Even though I strongly believe that padding should be always there for hairpin

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-08 Thread lilypond
Updates: Labels: Patch-new Comment #40 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c40 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-07 Thread lilypond
Comment #39 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 My patch implements the former of your requests (a little bit of padding). I'd like to get it smoothly integrated and then propose a second patch for the

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-07 Thread lilypond
Comment #38 on issue 2057 by prze...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 It looks it went in good direction except for hairpins touching span bar in case of those continuing on the next line: - they should still have padding

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-07 Thread lilypond
Comment #37 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Now that the original code is working as intended, I see that it makes a distinction between hairpins that end at the end of a line those that conti

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-05 Thread lilypond
Updates: Labels: Patch-review Comment #35 on issue 2057 by lilypond...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c35 Patchy the autobot says: LGTM. ___ bug-lilypond mailing list b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-05 Thread lilypond
Updates: Labels: Patch-new Comment #34 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c34 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-05 Thread lilypond
Updates: Labels: Patch-needs_work Comment #33 on issue 2057 by lilypond...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c33 Patchy the autobot says: fails to compile (at least) one of the regtests, but I can't tell which one d

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-05 Thread lilypond
Updates: Labels: Patch-new Comment #32 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c32 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-04 Thread lilypond
Comment #31 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 The bug-fix portion, split off as issue 2060, is in the code base and due to appear in development release 2.15.21. This fix gives the output at le

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-04 Thread lilypond
Updates: Labels: -Patch-review Patch-needs_work Comment #30 on issue 2057 by colinpkc...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Keith's comments on Rietveld. ___ bug-lilypond m

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-02 Thread lilypond
Updates: Labels: -Patch-new Patch-review Comment #29 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 PAsses make and make check James ___ bug-lilypond mailing

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-01 Thread lilypond
Updates: Labels: Patch-new Comment #28 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c28 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-12-01 Thread lilypond
Updates: Labels: -Patch-new Patch-needs_work Comment #27 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Fails make --snip-- [/home/jlowe/lilypond-git/ly/context-mods-init.ly] [/home/jlowe/lilypond-git

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #26 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c26 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___ bug-lilypond maili

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #25 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Mike's patch now incorporates my fix to shorten hairpins at end-of-line (issue 2060) and goes further: 1) if a Hairpin continues across the line-break

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #24 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 It started about too long hairpin in last measure in the line. The too-long hairpin in the last measure, longer that those in other measures, was d

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #23 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 What does Gould et. al. have to say about hairpins w/ respect to bar lines, line breaks & span bars? ___ b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Updates: Labels: Patch-new Comment #22 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c22 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #21 on issue 2057 by prze...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 It started about too long hairpin in last measure in the line. Why the padding is removed now for non-last measures? Does it require splitting into th

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-30 Thread lilypond
Comment #20 on issue 2057 by bealings...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I don't think the regtests look good. The new hairpins are hitting dynamics markings, and I think the old ones stopping short of the bar lines lo

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-29 Thread lilypond
Updates: Labels: -Patch-new Patch-review Comment #18 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Passes Make - reg tests attached James Attachments: Screenshot.png 110 KB __

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-29 Thread lilypond
Updates: Labels: Patch-new Comment #17 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c17 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-29 Thread lilypond
Updates: Labels: -Patch-new Patch-review Comment #16 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Passes make and make check James ___ bug-lilypond mailing

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #15 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I added issue 2060, with linked patch, to make the existing "bound-padding" be applied to hairpins consistently.

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #14 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Sorry - previous posted file was incorrect. Attachments: hairpin.pdf 36.8 KB ___ bug-lilypond maili

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #13 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Attached is the most recent version of the new regtest in light of the conversation about everything lining up. Attachments: xav.pdf 29.1 KB

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Updates: Labels: Patch-new Comment #12 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c12 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #11 on issue 2057 by prze...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 It's all about obtaining sane behavior and IMO hairpin length should be the same whether there is span bar or just bar. Is there any good reason to ma

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #10 on issue 2057 by carl.d.s...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 This second request seems to me to be a new issue, i.e. Hairpins in parallel with those shortened to avoid collisions with span bars should also b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #9 on issue 2057 by x.sche...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 +1, hairpin ends vertically aligned in a similar way. (i.e. I agree with the comment just above, #c8) ___ b

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #8 on issue 2057 by prze...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I think that for system's integrity and good looking result all hairpins should have equal length if defined in the same way, thus shortening should ha

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Comment #7 on issue 2057 by k-ohara5...@oco.net: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 I received a question about the desired behavior. Currently a hairpin below the staff group ends directly below the parallel hairpin above. At the en

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-28 Thread lilypond
Updates: Labels: -Patch-new Patch-review Comment #6 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Passes Make and make check james ___ bug-lilypond mailing l

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-27 Thread lilypond
Comment #5 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c5 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 ___ bug-lilypond mailing

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-27 Thread lilypond
Updates: Labels: Patch-new Comment #4 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c4 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 _

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-27 Thread lilypond
Updates: Status: Started Owner: mts...@gmail.com Labels: -Patch-new Patch-review Comment #2 on issue 2057 by pkx1...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 Passes Make and make check James __

Re: Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-27 Thread lilypond
Updates: Labels: Patch-new Comment #1 on issue 2057 by mts...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057#c1 Adds padding between Hairpins and SpanBars. http://codereview.appspot.com/5438060 _

Issue 2057 in lilypond: Hairpin hits barline at line break

2011-11-27 Thread lilypond
Status: Accepted Owner: Labels: Type-Ugly New issue 2057 by philehol...@gmail.com: Hairpin hits barline at line break http://code.google.com/p/lilypond/issues/detail?id=2057 %% Hairpin at a line break touches the barline, whereas for a normal bar %% (i.e. not at a line break) it does not.