Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-03-02 Thread lilypond
Updates: Status: Verified Comment #16 on issue 1470 by philehol...@googlemail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Hoorah! ___ bug-lilypond mailing list bug-lilypond@gnu.org

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-03-01 Thread lilypond
Updates: Status: Fixed Labels: -Patch-review fixed_2_13_52 Comment #15 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Thanks, pushed. ___ bug-lil

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-24 Thread lilypond
Updates: Labels: -Patch-needs_work Patch-review Comment #14 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 ok, I uploaded it. http://codereview.appspot.com/4243041 I'll add it to the next set of 48-

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-24 Thread lilypond
Updates: Labels: -Patch-review Patch-needs_work Comment #13 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 sorry, but I can't insist that other people review this without a reitveld issue. _

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-21 Thread lilypond
Updates: Labels: -Patch-new Patch-review Comment #12 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 lgtm, passes the regtests, but could we get this uploaded to reitveld? __

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-21 Thread lilypond
Comment #11 on issue 1470 by ahawry...@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Here's the promised patch, including appropriate changes to the regression tests and docs. The only change in the regression tests is test-out

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-19 Thread lilypond
Comment #10 on issue 1470 by philehol...@googlemail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 In my initial report, I said "In practice, on a real-world score of 30 pages, performance is only improved by 0.2%, and even with a contr

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-02-19 Thread lilypond
Comment #9 on issue 1470 by hanw...@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 @phil - I'm not sure the cost depends on whetehr the texts overflow or not. Can you check that this also does not have a lot of impact when you

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-29 Thread lilypond
Updates: Labels: Patch-new Comment #8 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 (No comment was entered for this change.) ___ bug-lilypond mailing l

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-28 Thread lilypond
Comment #7 on issue 1470 by ahawry...@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Ah, that explanation of the mensural ligatures makes sense. Given that the horizontal spacing with keep-inside-line == ##t is no more odd than th

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-28 Thread lilypond
Comment #6 on issue 1470 by benko@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Does anyone know why the 'mensural-ligatures' regression test would have been affected by keep-inside-line = ##t? mensural ligatures interact wi

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-17 Thread lilypond
Comment #5 on issue 1470 by ahawry...@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 This issue is an excellent frog task for me: I just built my first reg-test comparison. While some of them are funny looking (and should probab

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-16 Thread lilypond
Comment #4 on issue 1470 by percival.music.ca: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 By "it works great", I assume that you have create a regtest comparison and can argue that every change is acceptable? ;) http://lilypond.org/doc

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-15 Thread lilypond
Comment #3 on issue 1470 by ahawry...@gmail.com: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 I have tested the edit below and it works great. I can make the appropriate changes in documentation; should I also remove all of the 'keep-ins

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-08 Thread lilypond
Comment #2 on issue 1470 by Carl.D.Sorensen: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 No, the proper way to do it is to add a setting to each of the grobs PaperColumn and NonMusicalPaperColumn in scm/define-grobs.scm Thanks, Carl

Re: Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-08 Thread lilypond
Comment #1 on issue 1470 by PhilEHolmes: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 Presumably this could be done quite simply by adding \override PaperColumn #'keep-inside-line = ##t \override NonMusicalPaperColumn #'keep-inside-line = #

Issue 1470 in lilypond: Change keep-inside-line defaults to true

2011-01-07 Thread lilypond
Status: Accepted Owner: Labels: Type-Enhancement Priority-Medium Frog New issue 1470 by PhilEHolmes: Change keep-inside-line defaults to true http://code.google.com/p/lilypond/issues/detail?id=1470 By default, PaperColumn #'keep-inside-line and NonMusicalPaperColumn #'keep-inside-line are