Re: Cppcheck reports

2012-05-27 Thread Colin Hall
On Sat, May 26, 2012 at 07:39:57AM -0400, Mark Mathias wrote: > Colin, > > If you don't mind, I'm going to leave this to you. I don't understand it > enough to find a related issue or create a new one in the tracker... That's ok. Marek referred it to the devs and Carl Sorensen created a few track

Re: Cppcheck reports

2012-05-26 Thread Mark Mathias
Colin, If you don't mind, I'm going to leave this to you. I don't understand it enough to find a related issue or create a new one in the tracker... Also, I've cleared out all items from my "bug-current" folder today, so the bug squad should be caught up on that part of the checklist at this poin

Re: Cppcheck reports patch for 2546

2012-05-20 Thread Carl Sorensen
On May 20, 2012, at 1:16 PM, "Graham Percival" wrote: > On Sat, May 19, 2012 at 08:30:50AM +0200, Julien Nabet wrote: >> Since I don't have a Google account to sign in to >> http://codereview.appspot.com/, I attached the patch for 2546. >> Don't hesitate to tell me if it's ok or not. (I attache

Re: Cppcheck reports patch for 2546

2012-05-20 Thread Graham Percival
On Sat, May 19, 2012 at 08:30:50AM +0200, Julien Nabet wrote: > Since I don't have a Google account to sign in to > http://codereview.appspot.com/, I attached the patch for 2546. > Don't hesitate to tell me if it's ok or not. (I attached a link to > why prefix is better). Unfortunately we do not a

Re: Cppcheck reports patch for 2546

2012-05-20 Thread Julien Nabet
On 19/05/2012 00:36, Carl Sorensen wrote: Thanks for the file, Julien. I have split the warnings into various issues. See issues 2545, 2546, and 2548 through 2554 on the issue tracker. http://code.google.com/p/lilypond/issues/detail?id=2545&colspec=ID%20Type%2 0Status%20Stars%20Owner%20Patch%2

Re: Cppcheck reports

2012-05-20 Thread Julien Nabet
On 18/05/2012 22:27, Carl Sorensen wrote: On 5/18/12 1:42 PM, "Marek Klein" wrote: Hello 2012/5/17 Julien Nabet I'm not top posting. Hello, I just git clone Lilypond project and launched cppcheck (git updated today). I thought it could interest you, here are some examples : [lily/tuple

Re: Cppcheck reports

2012-05-18 Thread Carl Sorensen
Thanks for the file, Julien. I have split the warnings into various issues. See issues 2545, 2546, and 2548 through 2554 on the issue tracker. http://code.google.com/p/lilypond/issues/detail?id=2545&colspec=ID%20Type%2 0Status%20Stars%20Owner%20Patch%20Needs%20Summary http://code.google.com/p/l

Re: Cppcheck reports

2012-05-18 Thread Carl Sorensen
On 5/18/12 1:42 PM, "Marek Klein" wrote: > > > >Hello > >2012/5/17 Julien Nabet > >> >> I'm not top posting. >Hello, > >I just git clone Lilypond project and launched cppcheck (git updated >today). >I thought it could interest you, here are some examples : >[lily/tuplet-bracket.cc:594] -> [lil

Re: Cppcheck reports

2012-05-18 Thread Marek Klein
Hello 2012/5/17 Julien Nabet > > > > I'm not top posting. > Hello, > > I just git clone Lilypond project and launched cppcheck (git updated > today). > I thought it could interest you, here are some examples : > [lily/tuplet-bracket.cc:594] -> [lily/tuplet-bracket.cc:594]: (style) Same > express

Cppcheck reports

2012-05-17 Thread Julien Nabet
> > I'm not top posting. Hello, I just git clone Lilypond project and launched cppcheck (git updated today). I thought it could interest you, here are some examples : [lily/tuplet-bracket.cc:594] -> [lily/tuplet-bracket.cc:594]: (style) Same expression on both sides of '-' 592 if (!follow_be