Re: T405 - Respect user setting bracket-visibility property. (issue194095)

2010-02-22 Thread n . puttock
Sorry, here they are: http://codereview.appspot.com/194095/diff/2001/1003 File lily/tuplet-bracket.cc (right): http://codereview.appspot.com/194095/diff/2001/1003#newcode4 lily/tuplet-bracket.cc:4: Copyright (C) 1997--2009 Jan Nieuwenhuizen rebase again? http://codereview.appspot.com/194095/d

Re: T405 - Respect user setting bracket-visibility property. (issue194095)

2010-02-22 Thread n . puttock
On 2010/02/22 18:27:19, Ian Hulin wrote: Sorry if this sounds a bit jobsworth but I'd rather this patch went out the door as is and I'll look at your comment as part of work on a new tracker. Fair enough. Send me the patch when you've sorted the nitpicks below. Cheers, Neil http://coderev

T405 - Respect user setting bracket-visibility property. (issue194095)

2010-02-20 Thread n . puttock
Hi Ian, Looks OK, though don't you think it would be better to increase the size of the bracket if it's too small? Cheers, Neil http://codereview.appspot.com/194095/diff/1/2 File lily/tuplet-bracket.cc (right): http://codereview.appspot.com/194095/diff/1/2#newcode286 lily/tuplet-bracket.cc:28