Re: [tablatures] tremolos in tablature

2010-08-28 Thread Carl Sorensen
On 8/28/10 9:11 AM, "Neil Puttock" wrote: > On 28 August 2010 14:46, Marc Hohl wrote: > >> Just a little ping - is the patch ok, or should I load it to Rietveld? > > Looks OK apart from this: > > + %% NOTE: in lily/stem-tremolo.cc, we have length-fraction = 1, > + %% and the tablature st

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Neil Puttock
On 28 August 2010 16:17, Carl Sorensen wrote: > Why not use 1/staff-space?  This would adjust things regardless of how > staff-space was tweaked, wouldn't it? Yes. A simple helper function using ly:staff-symbol-staff-space would suffice (apart from 'beam-width, which needs a wrapper around ly:s

Re: Issue 1229 in lilypond: Notes may be placed above clef and key signature.

2010-08-28 Thread lilypond
Comment #4 on issue 1229 by n.puttock: Notes may be placed above clef and key signature. http://code.google.com/p/lilypond/issues/detail?id=1229 The examples which work in 2.12 rely on the default 'extra-spacing-height which used to be added to every Item. ___

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Neil Puttock
On 28 August 2010 14:46, Marc Hohl wrote: > Just a little ping - is the patch ok, or should I load it to Rietveld? Looks OK apart from this: + %% NOTE: in lily/stem-tremolo.cc, we have length-fraction = 1, + %% and the tablature staff space is scaled by 1.5, so we use 1/1.5=0.67 These commen

Re: [tablatures] tremolos in tablature

2010-08-28 Thread Marc Hohl
Marc Hohl schrieb: [...] Ok, so here is a patch. I had to adjust length-fraction as well, and it is strange that this is somewhat hard-coded in lily/stem-tremolo.cc, but since the default is 1, it probably doesn't matter. Marc Just a little ping - is the patch ok, or should I load it to Rietv