Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

2019-02-14 Thread Tom Tromey
> "Thomas" == Thomas Schwinge writes: Thomas> + struct cleanup *old_chain = make_cleanup (xfree, pathname); Please don't add new cleanups to gdb. We're in the process of removing them all. Instead you can use gdb::unique_xmalloc_ptr, or std::string, or a std::vector of some fla

Re: [pushed][PATCH v3 1/4] Extended-remote follow exec

2019-02-14 Thread Tom Tromey
>>>>> "Tom" == Tom Tromey writes: >>>>> "Thomas" == Thomas Schwinge writes: Thomas> + struct cleanup *old_chain = make_cleanup (xfree, pathname); Tom> Please don't add new cleanups to gdb. Tom> We'