Re: [RFC PATCH 1/5] misc: Convert daemon () to GNU coding style

2023-04-18 Thread Cristian Rodríguez
On Tue, Apr 18, 2023 at 8:02 AM Adhemerval Zanella Netto via Libc-alpha < libc-al...@sourceware.org> wrote: > > > On 17/04/23 19:58, Sergey Bugaev via Libc-alpha wrote: > > This is nicer, and is going to be required for the following changes > > to reasonably stay within the 79 column limit. > > >

Re: [RFC PATCH v2 4/7] csu: Fix standard fds' mode

2023-04-19 Thread Cristian Rodríguez
On Wed, Apr 19, 2023 at 12:02 PM Sergey Bugaev wrote: > stdin is supposed to be readable, stdout and stderr writable. Otherwise, > we get this: > > index de6dd716..ca4812cd 100644 > --- a/csu/check_fds.c > +++ b/csu/check_fds.c > @@ -90,7 +90,7 @@ __libc_check_standard_fds (void) > is reall

Re: [RFC PATCH v2 4/7] csu: Fix standard fds' mode

2023-04-20 Thread Cristian Rodríguez
On Thu, Apr 20, 2023 at 7:47 AM Adhemerval Zanella Netto < adhemerval.zane...@linaro.org> wrote: > > > > I am not really sure how effective is this hardening, it seems more a > development one to enforce that system daemon are spawned correctly. > Exactly, my understanding is that it is a futile

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Cristian Rodríguez
a On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha < libc-al...@sourceware.org> wrote: > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror () and similar > functions. > abort() and all the function wrappers called by