Re: [PATCH 01/14] USER32: change default to disabled and make it a general option

Applied, thanks! Luca Dariz, le jeu. 28 déc. 2023 20:42:48 +0100, a ecrit: > * configfrag.ac: add the global option USER32; although it makes sense > for 64-bit versions only, it can be used by future 64-bit > architectiures and not only x86_64. > Also, change the default setting to be disab

Re: [PATCH 02/14] add basic user-space tests with qemu

Hello, Thanks, this looks good! Luca Dariz, le jeu. 28 déc. 2023 20:42:49 +0100, a ecrit: > new file mode 100644 > index ..4cf25891 > --- /dev/null > +++ b/tests/README > @@ -0,0 +1,37 @@ > + > +There are some basic tests that can be run qith qemu. You can run all the > tests with > + >

Re: [PATCH 03/14] add mach_host tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:50 +0100, a ecrit: > --- > tests/test-mach_host.c | 54 ++ > 1 file changed, 54 insertions(+) > create mode 100644 tests/test-mach_host.c > > diff --git a/tests/test-mach_host.c b/tests/test-mach_host.c > new file mod

Re: [PATCH 02/14] add basic user-space tests with qemu

Hi, Il 29/12/23 14:37, Samuel Thibault ha scritto: Hello, Thanks, this looks good! Luca Dariz, le jeu. 28 déc. 2023 20:42:49 +0100, a ecrit: new file mode 100644 index ..4cf25891 --- /dev/null +++ b/tests/README @@ -0,0 +1,37 @@ + +There are some basic tests that can be run qith qemu.

Re: [PATCH 04/14] add gsync tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:51 +0100, a ecrit: > +static void single_t2(void *arg) > +{ > + int err; > + msleep(100); > + err = gsync_wake(mach_task_self(), (vm_offset_t)&single_shared, 0, 0); > + ASSERT_RET(err, "gsync_wake t2"); > + > + err = thread_terminate(mach_thread_self());

Re: [PATCH 02/14] add basic user-space tests with qemu

Luca Dariz, le ven. 29 déc. 2023 14:51:31 +0100, a ecrit: > Il 29/12/23 14:37, Samuel Thibault ha scritto: > > Luca Dariz, le jeu. 28 déc. 2023 20:42:49 +0100, a ecrit: > > > new file mode 100644 > > > index ..4cf25891 > > > --- /dev/null > > > +++ b/tests/README > > > @@ -0,0 +1,37 @@ > >

Re: [PATCH 02/14] add basic user-space tests with qemu

Il 29/12/23 14:57, Samuel Thibault ha scritto: Luca Dariz, le ven. 29 déc. 2023 14:51:31 +0100, a ecrit: Il 29/12/23 14:37, Samuel Thibault ha scritto: Luca Dariz, le jeu. 28 déc. 2023 20:42:49 +0100, a ecrit: new file mode 100644 index ..4cf25891 --- /dev/null +++ b/tests/README @@ -0

Re: [PATCH 02/14] add basic user-space tests with qemu

Hi, On Fri, Dec 29, 2023 at 02:51:31PM +0100, Luca Dariz wrote: > > > +$ gdb gnuamch > > > > Typo ;) > > What would be a better command? This is actually how I start gdb from the > build directory, You probably start gnumach though, and not gnuamch? Michael

Re: [PATCH 05/14] add mach_port tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:52 +0100, a ecrit: > + mach_port_t newname = 123; Why initializing it? > + err = mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, > &newname); > + ASSERT_RET(err, "mach_port_allocate"); > + err = mach_port_allocate(mach_task_self(), MACH_PO

Re: [PATCH 06/14] adjust range when changing memory pageabilityg

Luca Dariz, le jeu. 28 déc. 2023 20:42:53 +0100, a ecrit: > * vm/vm_map.c: if the start address is not in the map, try to find the > nearest entry instead of failing. > > This caused the initial vm_wire_all(host, task VM_WIRE_ALL) in glibc > startup to fail with KERN_NO_SPACE. > --- > vm/vm_map

Re: [PATCH 07/14] add basic vm tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:54 +0100, a ecrit: > + // this emulates maptime() > + struct mapped_time_value *mtime; > + mach_port_t device, memobj; > + int err = device_open (device_priv(), 0, "time", &device); > + ASSERT_RET(err, "device_open"); > + err = device_map (device, VM_PRO

Re: [PATCH 08/14] add thread creation helper to tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:55 +0100, a ecrit: > diff --git a/tests/testlib.c b/tests/testlib.c > index 6abe8c4d..e6be46ee 100644 > --- a/tests/testlib.c > +++ b/tests/testlib.c > @@ -95,3 +95,56 @@ void _start() >printf("%s: test %s exit code %x\n", TEST_SUCCESS_MARKER, argv[0], ret

Re: [PATCH 03/14] add mach_host tests

Il 29/12/23 14:44, Samuel Thibault ha scritto: Luca Dariz, le jeu. 28 déc. 2023 20:42:50 +0100, a ecrit: --- tests/test-mach_host.c | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 tests/test-mach_host.c diff --git a/tests/test-mach_host.

Re: [PATCH 09/14] add syscall tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:56 +0100, a ecrit: > --- > tests/test-syscalls.c | 149 ++ > 1 file changed, 149 insertions(+) > create mode 100644 tests/test-syscalls.c > > diff --git a/tests/test-syscalls.c b/tests/test-syscalls.c > new file mode

Re: [PATCH 10/14] expose MACH_MSG_USER_ALIGNMENT for manually-built messages

Applied, thanks! Luca Dariz, le jeu. 28 déc. 2023 20:42:57 +0100, a ecrit: > --- > include/mach/message.h | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/include/mach/message.h b/include/mach/message.h > index 0b8b34d4..9790ef98 100644 > --- a/includ

Re: [PATCH 11/14] add raw mach_msg tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:58 +0100, a ecrit: > --- > tests/test-machmsg.c | 390 +++ > 1 file changed, 390 insertions(+) > create mode 100644 tests/test-machmsg.c > > diff --git a/tests/test-machmsg.c b/tests/test-machmsg.c > new file mode 100

Re: [PATCH 12/14] add basic task tests

Luca Dariz, le jeu. 28 déc. 2023 20:42:59 +0100, a ecrit: > +void test_task() > +{ > + mach_port_t ourtask = mach_task_self(); > + mach_msg_type_number_t count; > + int err; > + > + struct task_basic_info binfo; > + count = TASK_BASIC_INFO_COUNT; > + err = task_info(ourtask, TASK_BASIC_INFO,

Re: [PATCH 13/14] add basic thread tests

Luca Dariz, le jeu. 28 déc. 2023 20:43:00 +0100, a ecrit: > --- > tests/test-threads.c | 88 > 1 file changed, 88 insertions(+) > create mode 100644 tests/test-threads.c > > diff --git a/tests/test-threads.c b/tests/test-threads.c > new file mode 1006

Re: [PATCH 14/14] add tests to make check

I'd say split this into the respective commits, so they are self-contained. Thanks for all that! Samuel Luca Dariz, le jeu. 28 déc. 2023 20:43:01 +0100, a ecrit: > --- > tests/user-qemu.mk | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tests/user-qemu.mk b/t

[PATCH mig] Use char* for inlined arrays of char in user headers

This changes how we declare RPC user prototypes for device_read_inband to use "char *data" rather than "io_buf_ptr_inband_t data". It is more standard to pass a pointer to represent arrays compared to "char [128]". This fixes a warning in console-client since GCC won't complain we are not passing a

[PATCH hurd 1/3] pfinet and pci-arbiter: update server handlers to return kern_return_t to fix -Werror=enum-int-mismatch warnings

--- pci-arbiter/pci-ops.c | 10 +++ pfinet/iioctl-ops.c | 10 +++ pfinet/io-ops.c | 64 +-- pfinet/main.c | 2 +- pfinet/pfinet-ops.c | 4 +-- pfinet/socket-ops.c | 32 +++--- pfinet/tunnel.c | 24 -

[PATCH hurd 2/3] Replace deprecated sigmask with sigset_t calls

--- exec/hashexec.c | 9 +++-- libdiskfs/disk-pager.c | 4 +++- libpager/pager-memcpy.c | 11 --- libstore/memobj.c | 11 --- startup/startup.c | 9 ++--- 5 files changed, 32 insertions(+), 12 deletions(-) diff --git a/exec/hashexec.c b/exec/hashexe

[PATCH hurd 3/3] Mark msg_thread as noreturn

--- boot/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/boot.c b/boot/boot.c index 0d7ae74..d773bd1 100644 --- a/boot/boot.c +++ b/boot/boot.c @@ -775,7 +775,7 @@ main (int argc, char **argv, char **envp) } } -void * +void * __attribute__ ((noreturn)) msg_

Re: [PATCH mig] Use char* for inlined arrays of char in user headers

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 11:08:14 -0500, a ecrit: > This changes how we declare RPC user prototypes for device_read_inband > to use "char *data" rather than "io_buf_ptr_inband_t data". It is more > standard to pass a pointer to represent arrays compared to "char [128]". T

Re: [PATCH hurd 1/3] pfinet and pci-arbiter: update server handlers to return kern_return_t to fix -Werror=enum-int-mismatch warnings

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 11:12:09 -0500, a ecrit: > --- > pci-arbiter/pci-ops.c | 10 +++ > pfinet/iioctl-ops.c | 10 +++ > pfinet/io-ops.c | 64 +-- > pfinet/main.c | 2 +- > pfinet/pfinet-ops.c | 4 +--

Re: [PATCH hurd 2/3] Replace deprecated sigmask with sigset_t calls

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 11:12:10 -0500, a ecrit: > --- > exec/hashexec.c | 9 +++-- > libdiskfs/disk-pager.c | 4 +++- > libpager/pager-memcpy.c | 11 --- > libstore/memobj.c | 11 --- > startup/startup.c | 9 ++--- > 5 fi

Re: [PATCH hurd 3/3] Mark msg_thread as noreturn

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 11:12:11 -0500, a ecrit: > --- > boot/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/boot/boot.c b/boot/boot.c > index 0d7ae74..d773bd1 100644 > --- a/boot/boot.c > +++ b/boot/boot.c > @@ -775,7 +775,7 @@ main (i

Re: [PATCH 04/14] add gsync tests

Il 29/12/23 14:56, Samuel Thibault ha scritto: Luca Dariz, le jeu. 28 déc. 2023 20:42:51 +0100, a ecrit: +static void single_t2(void *arg) +{ + int err; + msleep(100); + err = gsync_wake(mach_task_self(), (vm_offset_t)&single_shared, 0, 0); + ASSERT_RET(err, "gsync_wake t2"); + + err = thre

Re: [PATCH 04/14] add gsync tests

Luca Dariz, le ven. 29 déc. 2023 18:21:56 +0100, a ecrit: > I guess the exact value used in the synchronization is not relevant, > as long as it's the expected one. Yes. Samuel

[PATCH hurd 02/11] Cast bootinfo to struct diskfs_control * to silence warning

--- libdiskfs/boot-start.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c index e8c09bc..8c159f3 100644 --- a/libdiskfs/boot-start.c +++ b/libdiskfs/boot-start.c @@ -464,7 +464,7 @@ diskfs_S_fsys_getpriv (struct diskfs_control *

[PATCH hurd 08/11] proxy-defpager: add missing return statement

--- trans/proxy-defpager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/trans/proxy-defpager.c b/trans/proxy-defpager.c index 386f1b6..314ce9f 100644 --- a/trans/proxy-defpager.c +++ b/trans/proxy-defpager.c @@ -124,6 +124,8 @@ S_default_pager_paging_storage_new (mach_port_t default_page

[PATCH hurd 10/11] libftpconn: add out >= 2 condition to make GCC happy

--- libftpconn/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libftpconn/cmd.c b/libftpconn/cmd.c index 9916d03..4b4c6fa 100644 --- a/libftpconn/cmd.c +++ b/libftpconn/cmd.c @@ -99,7 +99,7 @@ ftp_conn_cmd (struct ftp_conn *conn, const char *cmd, const char *arg,

[PATCH hurd 07/11] Fix a few pointer related warnings.

--- utils/rpctrace.c | 4 ++-- utils/vmallocate.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/rpctrace.c b/utils/rpctrace.c index 589ce8f..f7046a0 100644 --- a/utils/rpctrace.c +++ b/utils/rpctrace.c @@ -810,10 +810,10 @@ print_contents (mach_msg_header_t *inp,

[PATCH hurd 09/11] Fix overflow issues in tmpfs and vmallocate

--- tmpfs/tmpfs.c | 2 +- utils/vmallocate.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tmpfs/tmpfs.c b/tmpfs/tmpfs.c index 02d4bd8..d28806a 100644 --- a/tmpfs/tmpfs.c +++ b/tmpfs/tmpfs.c @@ -39,7 +39,7 @@ char *diskfs_disk_name = "none"; int diskfs_default_s

[PATCH hurd 05/11] x86_64: utmp uses int32_t to store time so use a temporary variable

--- utils/login.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/utils/login.c b/utils/login.c index 3134c4a..3ed5121 100644 --- a/utils/login.c +++ b/utils/login.c @@ -157,12 +157,17 @@ static void add_utmp_entry (char *args, unsigned args_len, int inherit_host) {

[PATCH hurd 04/11] Fix printf format specifiers

--- pci-arbiter/options.c | 2 +- utils/ftpdir.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pci-arbiter/options.c b/pci-arbiter/options.c index e0455f4..e578810 100644 --- a/pci-arbiter/options.c +++ b/pci-arbiter/options.c @@ -379,7 +379,7 @@ netfs_append_args (

[PATCH hurd 01/11] Initialize a few error variables to avoid GCC warnings

--- ext2fs/pager.c | 2 +- fatfs/pager.c | 2 +- trans/random.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ext2fs/pager.c b/ext2fs/pager.c index 2869f4d..61db0df 100644 --- a/ext2fs/pager.c +++ b/ext2fs/pager.c @@ -170,7 +170,7 @@ static error_t file_pager_read_page (

[PATCH hurd 03/11] Use mach_msg_type_number_t whenever required to avoid warnings

--- libfshelp-tests/race.c | 9 + libnetfs/file-get-translator.c | 2 +- pfinet/ethernet.c | 2 +- pfinet/io-ops.c| 10 ++ utils/mount.c | 2 +- utils/msgport.c| 2 +- 6 files changed, 15 insertions(+), 12 d

[PATCH hurd 11/11] pfinet: fix type alias

--- pfinet/stubs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pfinet/stubs.c b/pfinet/stubs.c index 9affcff..01ba2fa 100644 --- a/pfinet/stubs.c +++ b/pfinet/stubs.c @@ -50,7 +50,7 @@ void dev_activate (struct device *) __attribute__ ((alias ("dev_init_scheduler")));

[PATCH hurd 06/11] x86_64: use 21 bytes in libps since %z might require more characters.

This makes GCC happy. --- libps/spec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libps/spec.c b/libps/spec.c index dec5704..9f64703 100644 --- a/libps/spec.c +++ b/libps/spec.c @@ -492,7 +492,7 @@ error_t ps_emit_nice_size_t (struct proc_stat *ps, struct ps_fmt_field *fi

Re: [PATCH hurd 01/11] Initialize a few error variables to avoid GCC warnings

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:20:55 -0500, a ecrit: > --- > ext2fs/pager.c | 2 +- > fatfs/pager.c | 2 +- > trans/random.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ext2fs/pager.c b/ext2fs/pager.c > index 2869f4d..61db0df 100644 > --- a

Re: [PATCH hurd 02/11] Cast bootinfo to struct diskfs_control * to silence warning

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:20:56 -0500, a ecrit: > --- > libdiskfs/boot-start.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c > index e8c09bc..8c159f3 100644 > --- a/libdiskfs/boot-start.c > +++

Re: [PATCH hurd 03/11] Use mach_msg_type_number_t whenever required to avoid warnings

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:20:57 -0500, a ecrit: > --- > libfshelp-tests/race.c | 9 + > libnetfs/file-get-translator.c | 2 +- > pfinet/ethernet.c | 2 +- > pfinet/io-ops.c| 10 ++ > utils/mount.c

Re: [PATCH hurd 04/11] Fix printf format specifiers

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:20:58 -0500, a ecrit: > --- > pci-arbiter/options.c | 2 +- > utils/ftpdir.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/pci-arbiter/options.c b/pci-arbiter/options.c > index e0455f4..e578810 100644 > --

Re: [PATCH hurd 05/11] x86_64: utmp uses int32_t to store time so use a temporary variable

Flavio Cruz, le ven. 29 déc. 2023 16:20:59 -0500, a ecrit: > --- > utils/login.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/utils/login.c b/utils/login.c > index 3134c4a..3ed5121 100644 > --- a/utils/login.c > +++ b/utils/login.c > @@ -157,12 +157,17 @@ static

Re: [PATCH hurd 06/11] x86_64: use 21 bytes in libps since %z might require more characters.

Flavio Cruz, le ven. 29 déc. 2023 16:21:00 -0500, a ecrit: > This makes GCC happy. > --- > libps/spec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libps/spec.c b/libps/spec.c > index dec5704..9f64703 100644 > --- a/libps/spec.c > +++ b/libps/spec.c > @@ -492,7 +492,7

Re: [PATCH hurd 07/11] Fix a few pointer related warnings.

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:21:01 -0500, a ecrit: > --- > utils/rpctrace.c | 4 ++-- > utils/vmallocate.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/utils/rpctrace.c b/utils/rpctrace.c > index 589ce8f..f7046a0 100644 > --- a/utils/rpct

Re: [PATCH hurd 08/11] proxy-defpager: add missing return statement

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:21:02 -0500, a ecrit: > --- > trans/proxy-defpager.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/trans/proxy-defpager.c b/trans/proxy-defpager.c > index 386f1b6..314ce9f 100644 > --- a/trans/proxy-defpager.c > +++ b/trans/proxy-

Re: [PATCH hurd 09/11] Fix overflow issues in tmpfs and vmallocate

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:21:03 -0500, a ecrit: > --- > tmpfs/tmpfs.c | 2 +- > utils/vmallocate.c | 7 +-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tmpfs/tmpfs.c b/tmpfs/tmpfs.c > index 02d4bd8..d28806a 100644 > --- a/tmpfs/tmpfs.c

Re: [PATCH hurd 10/11] libftpconn: add out >= 2 condition to make GCC happy

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:21:04 -0500, a ecrit: > --- > libftpconn/cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libftpconn/cmd.c b/libftpconn/cmd.c > index 9916d03..4b4c6fa 100644 > --- a/libftpconn/cmd.c > +++ b/libftpconn/cmd.c > @@

Re: [PATCH hurd 11/11] pfinet: fix type alias

Applied, thanks! Flavio Cruz, le ven. 29 déc. 2023 16:21:05 -0500, a ecrit: > --- > pfinet/stubs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pfinet/stubs.c b/pfinet/stubs.c > index 9affcff..01ba2fa 100644 > --- a/pfinet/stubs.c > +++ b/pfinet/stubs.c > @@ -50,7 +50