Re: [PATCH] Enable -Wmissing-prototypes.

2023-01-29 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 29 janv. 2023 01:09:00 -0500, a ecrit: > * Makefile.am: enable -Wmissing-prototypes > * ddb/db_inout.h: Prototype kdb_kintr for entering into DDB. > * ddb/db_mp.c Include ddb/db_input.h to get kdb_kintr. > * i386/i386at/kd.h: Include ddb/input.h to get kdb_kin

Re: [PATCH 1/4] i386/apic: Add ifdefs for APIC for mask/unmask irqs

2023-01-29 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le sam. 21 janv. 2023 08:04:44 +, a ecrit: > This prepares for --enable-ncpus=2 with --disable-apic option > > --- > i386/i386/apic.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/i386/i386/apic.h b/i386/i386/apic.h > index 10c83c01..0bb1bd73 100

Re: [PATCH 2/4] i386: Add AP variants of descriptor tables

2023-01-29 Thread Samuel Thibault
It seems most of my comments didn't get applied. To be able to progress at all, I commited this along with the changes I requested. Samuel Damien Zammit, le sam. 21 janv. 2023 08:04:52 +, a ecrit: > --- > i386/i386/apic.c| 6 ++ > i386/i386/gdt.c | 47 +++

Re: [PATCH 3/4] i386: Fix lapic and ioapic for smp

2023-01-29 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 21 janv. 2023 08:04:59 +, a ecrit: > --- > i386/i386/apic.c | 87 ++ > i386/i386/apic.h | 110 +-- > i386/i386/smp.c | 89 +- > i386/i386/smp.h

Re: [PATCH 4/4] Add cpu_number and cpuboot

2023-01-29 Thread Samuel Thibault
See my previous review on this, you haven't addressed by comments. Damien Zammit, le sam. 21 janv. 2023 08:05:06 +, a ecrit: > --- > i386/i386/cpu_number.c | 37 ++ > i386/i386/cpuboot.S| 164 + > 2 files changed, 201 insertions(+) > creat

Re: [RFC PATCH 2/3] hurd: Implement O_TMPFILE

2023-01-29 Thread Samuel Thibault
Hello, Sergey Bugaev, le lun. 12 déc. 2022 14:46:35 +0300, a ecrit: > diff --git a/sysdeps/mach/hurd/bits/fcntl.h b/sysdeps/mach/hurd/bits/fcntl.h > index 17dcb384..b898a0c5 100644 > --- a/sysdeps/mach/hurd/bits/fcntl.h > +++ b/sysdeps/mach/hurd/bits/fcntl.h > @@ -123,6 +123,11 @@ > # define O_CL

Re: [RFC PATCH 0/3] O_TMPFILE and SHM_ANON for the Hurd

2023-01-29 Thread Samuel Thibault
Hello, Sergey Bugaev, le lun. 12 déc. 2022 14:46:33 +0300, a ecrit: > Then, Linux also has memfd_create (), which makes a temp file without touching > any fs at all. This API is widely used in the Wayland ecosystem as the > recommended way to create shared memory. But such an approach would not w

Re: [PATCH 0/12 - gnumach] SMP almost working!

2023-01-29 Thread Samuel Thibault
Bleh, I missed adding your name to these commits. Sorry, there's way too much in my mbox plate not to make mistakes :/ Samuel Almudena Garcia, le mar. 25 oct. 2022 12:03:06 +, a ecrit: > Btw. Samuel, when you will apply these patches, could you add my name > together the Damien's name as co

Re: [PATCH 0/12 - gnumach] SMP almost working!

2023-01-29 Thread Samuel Thibault
Damien, please do fix your git commit logs, to make sure Almudena's name get credited. Samuel Samuel Thibault, le lun. 30 janv. 2023 00:33:46 +0100, a ecrit: > Bleh, I missed adding your name to these commits. > > Sorry, there's way too much in my mbox plate not to make mistakes :/ > > Samuel >

[PATCH] Remove support setting custom demuxers during signal handling.

2023-01-29 Thread Flavio Cruz
We seem to call only into the exception and message server routines. --- hurd/msgportdemux.c | 17 - 1 file changed, 17 deletions(-) diff --git a/hurd/msgportdemux.c b/hurd/msgportdemux.c index 7587beda43..676e2e5008 100644 --- a/hurd/msgportdemux.c +++ b/hurd/msgportdemux.c @@ -2

[PATCH] Include i386asm.h using i386/i386/i386.asm.h

2023-01-29 Thread Flavio Cruz
If we 1) build for x86_64 and 2) build in a separate directory, we will not have -Ii386 (-Ix86_64 instead) hence this file won't be found since it is autogenerated. --- i386/i386at/int_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/i386/i386at/int_init.c b/i386/i386at/

[PATCH] Use $(CC) instead of gcc to avoid relying on the host gcc.

2023-01-29 Thread Flavio Cruz
--- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 10d030b8..e31a875d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -41,7 +41,7 @@ AM_LDFLAGS = # Compilation flags # -GCC_INSTALL = $(shell LANG=C gcc -print-search-dirs | sed -n -