Re: [PATCH] hurd: Implement device memory mapping

El 12/12/21 a les 16:19, Samuel Thibault ha escrit: Don't we need else { pager = wobj; } ? Otherwise pager would be undefined. In the case when the two previous conditions are false, what about robj? can we be sure it's null and not leaked? When could the two previous conditions be fal

Re: [PATCH 1/3] libnetfs: new user callback: netfs_get_filemap()

> Rather than requiring the translator to provide a netfs_get_filemap > (which breaks compatibility for any existing translator using > libnetfs), you can add a weak definition in libnetfs, see for instance > libnetfs/set-get-trans.c. Like this? I'm also attaching the other two patches, since the

[PATCH 1/3] libnetfs: new user callback: netfs_get_filemap()

From: Joan Lledó Provide the user with a new callback so they can implement file mapping over file system nodes. * libnetfs/netfs.h: Add prototype for netfs_get_filemap --- libnetfs/netfs.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libnetfs/netfs.h b/libnetfs/netfs.h index 38182

[PATCH 3/3] pci-arbiter: Implement memory mapping over region files

From: Joan Lledó * pci-arbiter/Makefile: * Add device_map.c to sources * pci-arbiter/device_map.c: * pci-arbiter/device_map.h: * New module for device mapping * Relies on libpciaccess mapping methods * pci-arbiter/func_files.c: * io_region_file(): Use the new devic

[PATCH 2/3] libnetfs: Implement RPC: io_map

From: Marcus Brinkmann * libnetfs/iostubs.c: implement io_map --- libnetfs/iostubs.c | 46 +++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/libnetfs/iostubs.c b/libnetfs/iostubs.c index a5ff4504..df48f8b7 100644 --- a/libnetfs/iostubs.

Re: [PATCH] hurd: Implement device memory mapping

Joan Lledó, le dim. 19 déc. 2021 12:14:18 +0100, a ecrit: > El 12/12/21 a les 16:19, Samuel Thibault ha escrit: > > > > Don't we need > > > > else { pager = wobj; } ? > > > > Otherwise pager would be undefined. > > In the case when the two previous conditions are false, what about robj? can > w

Re: [PATCH 1/3] libnetfs: new user callback: netfs_get_filemap()

Joan Lledó, le dim. 19 déc. 2021 12:26:45 +0100, a ecrit: > From: Joan Lledó > > Provide the user with a new callback so they can implement file > mapping over file system nodes. > > * libnetfs/netfs.h: Add prototype for netfs_get_filemap This only provides the declaration. As I said, see how

Re: [PATCH 2/3] rumpdisk: Link with rumpvfs_nofifofs

Again, why is this needed? Damien Zammit, le sam. 18 déc. 2021 17:08:46 +1100, a ecrit: > --- > rumpdisk/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rumpdisk/Makefile b/rumpdisk/Makefile > index cf7c9df0..0bfebfe6 100644 > --- a/rumpdisk/Makefile > +++ b/rum

Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

Hello, A commit log message needs to include the "why" of the commit. Damien Zammit, le sam. 18 déc. 2021 17:08:45 +1100, a ecrit: > --- > rumpdisk/block-rump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c > index 398289fb..8c29dc01 1006

Re: [PATCH 3/3] rumpdisk: Use raw uncached character device rwdXd

Damien Zammit, le sam. 18 déc. 2021 17:08:47 +1100, a ecrit: > This disables the rump buffer cache and avoids any magic translation that > rump would do. > > * rumpdisk/block-rump.c (translate_name): Use `/dev/r%sd' format instead of > `/dev/%sd'. Does this depend on the two previous patches? Doe