Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Andreas Schwab
On Dez 29 2019, Samuel Thibault wrote: > diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c > index 0c19b3223c..3d7317cec4 100644 > --- a/sysdeps/mach/hurd/sendmsg.c > +++ b/sysdeps/mach/hurd/sendmsg.c > @@ -108,7 +108,7 @@ __libc_sendmsg (int fd, const struct msghdr *message,

Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Samuel Thibault
Andreas Schwab, le dim. 29 déc. 2019 18:12:02 +0100, a ecrit: > > - for (; cmsg; cmsg = CMSG_NXTHDR (message, cmsg)) > > + for (; cmsg; cmsg = CMSG_NXTHDR ((struct msghdr *) message, cmsg)) > > Why is the first argument of __cmsg_nxthdr not const? I don't know, it is so on other systems as well

Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Andreas Schwab
On Dez 29 2019, Samuel Thibault wrote: > Andreas Schwab, le dim. 29 déc. 2019 18:12:02 +0100, a ecrit: >> > - for (; cmsg; cmsg = CMSG_NXTHDR (message, cmsg)) >> > + for (; cmsg; cmsg = CMSG_NXTHDR ((struct msghdr *) message, cmsg)) >> >> Why is the first argument of __cmsg_nxthdr not const? >

Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Samuel Thibault
Andreas Schwab, le dim. 29 déc. 2019 19:08:37 +0100, a ecrit: > On Dez 29 2019, Samuel Thibault wrote: > > > Andreas Schwab, le dim. 29 déc. 2019 18:12:02 +0100, a ecrit: > >> > - for (; cmsg; cmsg = CMSG_NXTHDR (message, cmsg)) > >> > + for (; cmsg; cmsg = CMSG_NXTHDR ((struct msghdr *) message

Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Andreas Schwab
On Dez 29 2019, Florian Weimer wrote: > * Andreas Schwab: > >> On Dez 29 2019, Samuel Thibault wrote: >> >>> diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c >>> index 0c19b3223c..3d7317cec4 100644 >>> --- a/sysdeps/mach/hurd/sendmsg.c >>> +++ b/sysdeps/mach/hurd/sendmsg.c >>

Re: [hurd,commited] hurd sendmsg: Fix warning on calling CMSG_*HDR

2019-12-29 Thread Florian Weimer
* Andreas Schwab: > On Dez 29 2019, Samuel Thibault wrote: > >> diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c >> index 0c19b3223c..3d7317cec4 100644 >> --- a/sysdeps/mach/hurd/sendmsg.c >> +++ b/sysdeps/mach/hurd/sendmsg.c >> @@ -108,7 +108,7 @@ __libc_sendmsg (int fd, con