Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Joseph Myers
On Mon, 2 Apr 2018, Samuel Thibault wrote: > This means that build-glibcs i686-gnu now builds fine. Among the > remaining TODOs, there are If you use mainline GCC, however, it fails: ../sysdeps/mach/hurd/if_index.c: In function '__if_nametoindex': ../sysdeps/mach/hurd/if_index.c:40:3: error: 's

Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Samuel Thibault
Joseph Myers, on mar. 03 avril 2018 15:45:13 +, wrote: > On Mon, 2 Apr 2018, Samuel Thibault wrote: > > > This means that build-glibcs i686-gnu now builds fine. Among the > > remaining TODOs, there are > > If you use mainline GCC, however, it fails: > > ../sysdeps/mach/hurd/if_index.c: In f

Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Joseph Myers
The build for i686-gnu also fails using GCC 6 branch with build-many-glibcs.py: hurdsig.c: In function 'interrupted_reply_port_location.isra.1': hurdsig.c:250:39: error: 'portloc' may be used uninitialized in this function [-Werror=maybe-uninitialized] *(volatile mach_port_t *) portloc = *por

Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Samuel Thibault
Joseph Myers, on mar. 03 avril 2018 21:48:32 +, wrote: > The build for i686-gnu also fails using GCC 6 branch with > build-many-glibcs.py: > > hurdsig.c: In function 'interrupted_reply_port_location.isra.1': > hurdsig.c:250:39: error: 'portloc' may be used uninitialized in this function > [-

Re: [hurd,commited] hurd: Make __if_nametoindex return ENODEV if ifname is too long

2018-04-03 Thread Samuel Thibault
Andreas Schwab, on mar. 03 avril 2018 23:24:54 +0200, wrote: > On Apr 03 2018, Samuel Thibault wrote: > > + strncpy (ifr.ifr_name, ifname, IFNAMESIZ - 1); > > That leaves ifr.ifr_name[IFNAMESIZ - 1] uninitialized. D'oh... If I wasn't seemingly all alone actually working on patches for the Hurd

Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Zack Weinberg
On Tue, Apr 3, 2018 at 5:58 PM, Samuel Thibault wrote: > Joseph Myers, on mar. 03 avril 2018 21:48:32 +, wrote: >> The build for i686-gnu also fails using GCC 6 branch with >> build-many-glibcs.py: >> >> hurdsig.c: In function 'interrupted_reply_port_location.isra.1': >> hurdsig.c:250:39: erro

Re: [hurd, commited] hurd: Make __if_nametoindex return ENODEV if ifname is too long

2018-04-03 Thread Joshua Branson
Hey Samuel, I wish I had the technical expertise on helping you in maintaining the Hurd port. :( You are doing awesome work, and maybe someday I'll be able to help out! On Tue, Apr 3, 2018, at 3:03 PM, Samuel Thibault wrote: > Andreas Schwab, on mar. 03 avril 2018 23:24:54 +0200, wrote: > >

Re: [hurd, commited] hurd: Make __if_nametoindex return ENODEV if ifname is too long

2018-04-03 Thread Samuel Thibault
Joshua Branson, on mar. 03 avril 2018 15:15:49 -0700, wrote: > I wish I had the technical expertise on helping you in maintaining the Hurd > port. :( It is a matter of working on it. Really, like everybody I started with knowing nothing, and I just studied code, tried stuff, made a lot of mis

Re: Upstreaming the glibc Hurd port

2018-04-03 Thread Joseph Myers
On Tue, 3 Apr 2018, Zack Weinberg wrote: > On Tue, Apr 3, 2018 at 5:58 PM, Samuel Thibault > wrote: > > Joseph Myers, on mar. 03 avril 2018 21:48:32 +, wrote: > >> The build for i686-gnu also fails using GCC 6 branch with > >> build-many-glibcs.py: > >> > >> hurdsig.c: In function 'interrupt