[RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
* i386/i386at/kd.c (kdstart): Moved escape sequence handling to new kd_putc_esc function. (kd_putc_esc): New function with logic from kdstart. (kdcnputc): Call kd_putc_esc rather than kd_putc to allow for ANSI escape codes. * i386/i386at/kd.h (kd_putc_esc): New function. --- i386/i386at/kd.c | 63

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:15:29 +0100, a écrit : > @@ -1069,33 +1068,12 @@ kdstart(struct tty *tp) > break; > if ((tp->t_outq.c_cc <= 0) || (ch = getc(&tp->t_outq)) == -1) > break; > - c = ch; > /* >

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd is actually using escape codes. I was trying to decide whether putc should handle escape codes or whether it should be left as outputting raw bytes to the display. As you can see I chose the latter, but do you think tha

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:42:38 +0100, a écrit : > Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd > is actually using escape codes. > > I was trying to decide whether putc should handle escape codes or whether it > should be left as outputting raw bytes to

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
I never gave that as an option? James > On 29 Aug 2015, at 11:44, Samuel Thibault wrote: > > James Clarke, le Sat 29 Aug 2015 11:42:38 +0100, a écrit : >> Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd >> is actually using escape codes. >> >> I was trying to decid

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:53:57 +0100, a écrit : > I never gave that as an option? ? I understand even less. AIUI, before kd_start had esc support; with your patch it doesn't have any more. Probably Mach/Hurd never made use of it, but that's probably not a reason for removing the suppo

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
Yes, that was a mistake, it should call kd_putc_esc. James > On 29 Aug 2015, at 11:55, Samuel Thibault wrote: > > James Clarke, le Sat 29 Aug 2015 11:53:57 +0100, a écrit : >> I never gave that as an option? > > ? I understand even less. AIUI, before kd_start had esc support; with > your patc

Re: netdde drivers

2015-08-29 Thread Robert Millan
Hi Samuel El 29/08/15 a les 00:17, Samuel Thibault ha escrit: Hello, As it seems we'll never synchronize netdde with DDE but rather go with Rump, That's an interesting proposition. Is someone working on a Rump-based network translator? FYI, I'm currently trying to get the remaining parts of

Re: netdde drivers

2015-08-29 Thread Samuel Thibault
Robert Millan, le Sat 29 Aug 2015 21:37:04 +0200, a écrit : > El 29/08/15 a les 00:17, Samuel Thibault ha escrit: > >As it seems we'll never synchronize netdde with DDE but rather go with > >Rump, > > That's an interesting proposition. Is someone working on a Rump-based > network translator? Not

ext2fs crashes

2015-08-29 Thread Samuel Thibault
Hello, Just to report that ext2fs crashes from times to times with ext2fs: ../../libports/../libshouldbeinlibc/refcount.h:165: refcounts_ref: Assertion `! (r.hard == 1 && r.weak == 0) || !"refcount detected use-after-free!"' failed. Samuel

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
Applied with the kd_putc_esc call fixed, thanks! Samuel

Re: [PATCH] Change file_utimes RPC to use a struct timespec and update the servers to use UTIME_NOW and UTIME_OMIT.

2015-08-29 Thread Samuel Thibault
Hello, Thanks for working on this! Flávio Cruz, le Sat 29 Aug 2015 03:35:56 +0100, a écrit : > These two patches allow the glibc and the hurd servers to handle UTIME_OMIT > and UTIME_NOW in futimens. > The file_utimes RPC now uses a struct timespec instead of a timeval. Well, we can't really ch

Re: [PATCH] Change file_utimes RPC to use a struct timespec and update the servers to use UTIME_NOW and UTIME_OMIT.

2015-08-29 Thread Samuel Thibault
Samuel Thibault, le Sun 30 Aug 2015 02:24:46 +0200, a écrit : > Flávio Cruz, le Sat 29 Aug 2015 03:35:56 +0100, a écrit : > > These two patches allow the glibc and the hurd servers to handle UTIME_OMIT > > and UTIME_NOW in futimens. > > The file_utimes RPC now uses a struct timespec instead of a t

Re: netdde drivers

2015-08-29 Thread Diego Nieto Cid
Hi Sorry, I meant to send this to the list too but failed to do so. El sáb., 29 de agosto de 2015 17:58, Robert Millan escribió: El 29/08/15 a les 21:56, Diego Nieto Cid ha escrit: > > > Hi > > > El sáb., 29 de agosto de 2015 16:37, Robert Millan > escribió: > > > > That's an interesting