RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Svante Signell
Hello, The attached test case gnat-4.9-test.tar.gz is a stripped-down version of the gnat-4.9 build with a custom fakeroot-hurd script. With the current version of fakeroot-hurd, the build fails. The attached patch trans_fakeroot.patch fixes this. The idea is to limit the openmodes according to

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Samuel Thibault
Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > The idea is to limit the openmodes according to the values defined in > struct netnode and to change the test for overlapping sets. In which case is this needed? What happens in that case and how the patch fixes this? A patch should b

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Svante Signell
On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > > The idea is to limit the openmodes according to the values defined in > > struct netnode and to change the test for overlapping sets. > > In which case is this needed? What

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Samuel Thibault
Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit : > On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > > > The idea is to limit the openmodes according to the values defined in > > > struct netnode and to change th

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Svante Signell
On Tue, 2015-05-12 at 11:22 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit : > > On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote: > > > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > > > > The idea is to limit the openmodes accord

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Samuel Thibault
Svante Signell, le Tue 12 May 2015 11:39:19 +0200, a écrit : > On Tue, 2015-05-12 at 11:22 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit : > > > On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote: > > > > Svante Signell, le Tue 12 May 2015 09:15:

RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-12 Thread Svante Signell
On Thu, 2015-05-07 at 16:51 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 07 May 2015 10:14:23 +0200, a écrit : > > I think I understand most of your writing above :) > > > > Should the netfs_set_translator stub be implemented in trans/fakeroot.c > > or in libnetfs/set-get-trans.c? > >

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-12 Thread Samuel Thibault
Hello, Svante Signell, le Tue 12 May 2015 22:09:33 +0200, a écrit : > netfs_attempt_chmod() returns an error of EOPNOTSUPP and hits the > fallback case calling the stub in > libnetfs/set-get-trans.c:netfs_set_translator() returning EOPNOTSUPP. > > Implementing netfs_S_file_set_translator() callin

Re: RFC: [PATCH] trans/fakeroot.c

2015-05-12 Thread Samuel Thibault
Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit : > On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote: > > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit : > > > The idea is to limit the openmodes according to the values defined in > > > struct netnode and to change th