Re: [PATCH 1/2] Fix some minor issues.

2009-08-14 Thread Sergiu Ivanov
Hello, On Wed, Aug 12, 2009 at 02:42:59PM +0200, olafbuddenha...@gmx.net wrote: > On Mon, Aug 10, 2009 at 11:11:41PM +0300, Sergiu Ivanov wrote: > > > * eth-multiplexer/device_impl.c (ds_device_open): Check if > > openstat flags are a subset of mode flags (not conversely). > > * eth-multiplexer/v

[PATCH 1/3] Add the ``--mount'' command line option.

2009-08-14 Thread Sergiu Ivanov
>From dd032b7115d3ed903ba97ff9bb98135e1033d715 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Sun, 5 Jul 2009 22:39:09 +0300 Subject: [PATCH 1/3] Add the ``--mount'' command line option. * Makefile (OBJS): Add mount.o * options.h (OPT_MOUNT, OPT_LONG_MOUNT): Define. * options.c (argp_common_o

Re: [PATCH] Implement the sync libnetfs stubs.

2009-08-14 Thread Sergiu Ivanov
Hello, On Tue, Aug 11, 2009 at 11:42:41AM +0200, Thomas Schwinge wrote: > This comment is based on the version of the patch that you installed into > master. (By the way: this commit didn't show up on commit-hurd; I'll > have a look at that.) Is it my duty to look after my commits showing up on

[PATCH] Implement the sync libnetfs stubs.

2009-08-14 Thread Sergiu Ivanov
>From d814b3960af9a1cda9c92f1323662a1f2ce02a54 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Wed, 8 Jul 2009 18:46:58 + Subject: [PATCH] Implement the sync libnetfs stubs. * netfs.c (netfs_attempt_sync): Sync every writable directory associated with the supplied node. (netfs_attempt_sync

Re: [PATCH] Fix the ``--priority'' option handling in netfs_append_args.

2009-08-14 Thread Sergiu Ivanov
Hello, On Tue, Aug 11, 2009 at 11:49:03AM +0200, Thomas Schwinge wrote: > On Tue, Aug 11, 2009 at 12:03:59AM +0300, Sergiu Ivanov wrote: > > * netfs.c (netfs_append_args): Change the format specification > > to ``%d''. > > OK for master, but please use ``* netfs.c (netfs_append_args) : > Change t

Re: [PATCH 1/4] Add the ``--no-mount'' option.

2009-08-14 Thread Sergiu Ivanov
Hello, > Most of the time, a good patch is one resulting in the cleanest (most > obvious) code. Keeping the patch itself simpler is not a goal, except in > bugfix releases. Hm... A very good point. I'll keep this in mind for the future, thank you. Regards, scolobb

Re: Unionmount: proxying the control port

2009-08-14 Thread Sergiu Ivanov
Hello, On Wed, Aug 12, 2009 at 02:42:29PM +0200, olafbuddenha...@gmx.net wrote: > Hi, > > On Mon, Aug 10, 2009 at 04:40:04PM +0300, Sergiu Ivanov wrote: > > On Fri, Aug 07, 2009 at 11:00:03PM +0200, olafbuddenha...@gmx.net > > wrote: > > > On Mon, Aug 03, 2009 at 08:59:15PM +0300, Sergiu Ivanov w

[PATCH 3/4] Reload fd ioctl handler on each call to ioctl

2009-08-14 Thread Carl Fredrik Hammar
* hurd/hurdioctl.c (_hurd_dummy_ioctl_handler): New function. * hurd/hurd/ioctl.h (_hurd_dummy_ioctl_handler): Likewise. * hurd/fd-ioctl-call.c: New file. * hurd/hurd/fd.h: Update copyright years. (_hurd_fd_call_ioctl_handler): New function declaration. * hurd/Makefile: Update copyright years. (use

[PATCH 2/4] Cast with ioctl_handler_t instead of its definition

2009-08-14 Thread Carl Fredrik Hammar
* hurd/hurd/ioctl.h (_HURD_HANDLE_IOCTLS_1): Cast to `ioctl_handler_t' type. --- hurd/hurd/ioctl.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hurd/hurd/ioctl.h b/hurd/hurd/ioctl.h index ee156f0..e5ab3dc 100644 --- a/hurd/hurd/ioctl.h +++ b/hurd/hurd/ioctl.h @@ -57,7

[PATCH 1/4] Don't resolve FD's port and ctty twice for TIOCSCTTY

2009-08-14 Thread Carl Fredrik Hammar
* hurd/hurdioctl.c (tiocsctty): Only get FD ports, do work in... (tiocsctty_internal): ...this new function. --- hurd/hurdioctl.c | 31 --- 1 files changed, 20 insertions(+), 11 deletions(-) diff --git a/hurd/hurdioctl.c b/hurd/hurdioctl.c index 96d910b..13a1a78 1006

[PATCH 4/4] Save handlers between calls to ioctl

2009-08-14 Thread Carl Fredrik Hammar
* hurd/hurd/ioctl.h (ioctl_handler_t): Move from here... * hurd/hurd/fd.h (ioctl_handler_t): ...to here. Change return type. Add `d', `crit', and `result' arguments. Change all callers and ioctl handlers. (hurd_fd): Add ioctl handler members. * hurd/fd-close.c: Update copyright years. (_hurd_fd_clo

[PATCH 0/4] Load ioctl handlers from server

2009-08-14 Thread Carl Fredrik Hammar
Hi, here comes a patch series that implements the brunt of the glibc side of loading ioctl handlers from servers. The only major missing part is the reverse authentication to establishes trust in the server. Though this is pretty orthogonal and requires more changes to the Hurd than glibc. So I

File handles in nfsd

2009-08-14 Thread Sergiu Ivanov
Hello, I am Sergiu Ivanov. This summer I am working on the implementing the VFS-style union-mounting functionality in GNU/Hurd. This means setting a translator on a node in such a way that it's filesystem gets merged with the underlying node's filesystem instead of covering it. In the current im

Re: [PATCH] Implement the sync libnetfs stubs.

2009-08-14 Thread Thomas Schwinge
Hello! On Fri, Aug 14, 2009 at 04:36:45PM +0300, Sergiu Ivanov wrote: > On Tue, Aug 11, 2009 at 11:42:41AM +0200, Thomas Schwinge wrote: > > This comment is based on the version of the patch that you installed into > > master. (By the way: this commit didn't show up on commit-hurd; I'll > > have

[PATCH] Don't stop when syncing a directory returns an error.

2009-08-14 Thread Sergiu Ivanov
* netfs.c (netfs_attempt_sync): Move err inside the loop. Declare final_err. On an error, store the error and go to the next item. Check for the directory port being NULL. --- Hello, On Fri, Aug 14, 2009 at 05:18:59PM +0200, Thomas Schwinge wrote: > On Fri, Aug 14, 2009 at 04:36:45PM +0300, Ser

Re: [PATCH] Don't stop when syncing a directory returns an error.

2009-08-14 Thread Thomas Schwinge
Hello! On Fri, Aug 14, 2009 at 07:41:08PM +0300, Sergiu Ivanov wrote: > On Fri, Aug 14, 2009 at 05:18:59PM +0200, Thomas Schwinge wrote: > > Why did you send it in a separate message by the way? Anyways, I'll post > > my few comments in here. > > I just didn't think about sending it in one messa

[PATCH] Don't stop when syncing a directory returns an error.

2009-08-14 Thread Sergiu Ivanov
* netfs.c (netfs_attempt_sync): Move err inside the loop. Declare final_err. On an error, store the error and go to the next item. Check for the directory port being NULL. --- Hello, On Fri, Aug 14, 2009 at 08:26:18PM +0200, Thomas Schwinge wrote: > On Fri, Aug 14, 2009 at 07:41:08PM +0300, Ser

Re: [PATCH] Don't stop when syncing a directory returns an error.

2009-08-14 Thread Thomas Schwinge
Hello! On Fri, Aug 14, 2009 at 10:26:10PM +0300, Sergiu Ivanov wrote: > On Fri, Aug 14, 2009 at 08:26:18PM +0200, Thomas Schwinge wrote: > > On Fri, Aug 14, 2009 at 07:41:08PM +0300, Sergiu Ivanov wrote: > > > On Fri, Aug 14, 2009 at 05:18:59PM +0200, Thomas Schwinge wrote: > > >node_ulfs_iter