Re: the big term patch

2002-02-10 Thread Marcus Brinkmann
On Fri, Feb 08, 2002 at 09:39:59PM -0500, Roland McGrath wrote: > It would be ideal to separate the commits into: bottomhalf interface > changes, using argp, and adding the hurdio bottomhalf. Did that. I found one critical bug, too, which might explain some of the weirdness I saw when testing (i

Re: the big term patch

2002-02-08 Thread Roland McGrath
This stuff all looks great. As usual, Marcus, you rule. It would be ideal to separate the commits into: bottomhalf interface changes, using argp, and adding the hurdio bottomhalf. But if you don't want to bother then I don't really care. But please do clean up the log entries not to make refer

Re: the big term patch

2002-02-08 Thread Marcus Brinkmann
On Fri, Feb 08, 2002 at 07:03:02PM +0100, Marcus Brinkmann wrote: > here is a fix on top of the other patch and here a patch on top of the patch on top of the patch. The whole patch is now available at ftp://alpha.gnu.org/gnu/hurd/contrib/marcus/term.diff This patch adds argp parsing to term, a

Re: the big term patch

2002-02-08 Thread Marcus Brinkmann
Hi, talking to myself again ;) here is a fix on top of the other patch. It is removing the constructor functions and replaces them by init functions that are part of the bottom handler interface. This also cleans up a special casing for ptyio_init. This way, root permission should not be neces

Re: the big term patch

2002-02-08 Thread Marcus Brinkmann
On Fri, Feb 08, 2002 at 07:03:02PM +0100, Marcus Brinkmann wrote: > here is a fix pfft. diff -ur term.new.old/ChangeLog term.new/ChangeLog --- term.new.old/ChangeLog Thu Feb 7 00:29:05 2002 +++ term.new/ChangeLog Fri Feb 8 19:02:21 2002 @@ -1,4 +1,26 @@ -2002-02-07 Marcus Brinkmann <[E

Re: the big term patch

2002-02-07 Thread Marcus Brinkmann
On Thu, Feb 07, 2002 at 03:16:52PM +0100, Marcus Brinkmann wrote: > The next step will be to test it with a fifo, there > seems to be a problem in draining the output for that. Groan, so much stupidity hurts. Of course it can't work, as a fifo shortcuts input and output of terms bottom handler.

the big term patch

2002-02-07 Thread Marcus Brinkmann
Hi, this is my current version of the error handling patch plus my new hurdio.c bottom handler. I can provide (and apply) both patches seperately, but there is not much overlap anyway, and it's time for me to not only talk about the hurdio bottom handler but also to show it to you. It seems to