Re: io_select support for netfs

2004-09-11 Thread Roland McGrath
> 2004-07-28 Marco Gerards <[EMAIL PROTECTED]> > > * io-select.c: Include . > (netfs_S_io_select): Add arguments `reply' and `replytype'. > * mutations.h (IO_SELECT_REPLY_PORT): New macro. That is fine. Please commit it. Thanks, Roland

Re: io_select support for netfs

2004-09-11 Thread Marco Gerards
[EMAIL PROTECTED] (Thomas Bushnell, BSG) writes: > Marco Gerards <[EMAIL PROTECTED]> writes: > >> In libnetfs/mutations.h the macro IO_SELECT_REPLY_PORT is not >> defined. That means that the netfs_S_io_select function does not get >> the reply port. >> >> If someone wants to override netfs_S_io

Re: io_select support for netfs

2004-07-29 Thread Thomas Bushnell, BSG
Bas Wijnen <[EMAIL PROTECTED]> writes: > Even without network you should be careful. If you have a > multithreaded program, or a source which is read by multiple > processes, or some other reason the state can have changed without > the selecting thread doing anything, you may not be able to read

Re: io_select support for netfs

2004-07-29 Thread Marco Gerards
[EMAIL PROTECTED] (Thomas Bushnell, BSG) writes: > Marco Gerards <[EMAIL PROTECTED]> writes: > >> In libnetfs/mutations.h the macro IO_SELECT_REPLY_PORT is not >> defined. That means that the netfs_S_io_select function does not get >> the reply port. >> >> If someone wants to override netfs_S_io

Re: io_select support for netfs

2004-07-29 Thread Bas Wijnen
On Wed, Jul 28, 2004 at 01:53:47PM -0700, Thomas Bushnell, BSG wrote: > > Be very careful in general with select on network thingies. This > doesn't apply to your use, but I want it on the record. To return > select true means that you can immediately do I/O with no waiting. > > That means that

Re: io_select support for netfs

2004-07-28 Thread Thomas Bushnell, BSG
Marco Gerards <[EMAIL PROTECTED]> writes: > In libnetfs/mutations.h the macro IO_SELECT_REPLY_PORT is not > defined. That means that the netfs_S_io_select function does not get > the reply port. > > If someone wants to override netfs_S_io_select, the function simply > won't work correctly becaus

io_select support for netfs

2004-07-28 Thread Marco Gerards
Hi, In libnetfs/mutations.h the macro IO_SELECT_REPLY_PORT is not defined. That means that the netfs_S_io_select function does not get the reply port. If someone wants to override netfs_S_io_select, the function simply won't work correctly because the reply port is required. The patch for the c