Re: Aren't spinlocks missing a memory clobber? [Was: ext2fs crashes lately]

2010-03-21 Thread Samuel Thibault
Thomas Schwinge, le Sat 20 Mar 2010 10:23:06 +0100, a écrit : > Yet, I just hit that one again: > > ext2fs: /var/tmp/hurd-20090404/./libports/port-ref.c:31: ports_port_ref: > Assertion `pi->refcnt || pi->weakrefcnt' failed. > > Samuel, I presume that version does include the glibc fix? Yes.

Re: Aren't spinlocks missing a memory clobber? [Was: ext2fs crashes lately]

2010-03-20 Thread Thomas Schwinge
On Sat, Aug 02, 2008 at 02:22:05AM +0100, Samuel Thibault wrote: > Barry deFreese, le Thu 24 Jul 2008 22:19:16 -0400, a écrit : > > ext2fs.static: > > /var/tmp/hurd-20071119/build-tree/hurd/libports/port-ref.c:31:ports_port_ref: > > > > Assertion 'pi->refcnt || pi->weakrefcnt' failed. > > Quite

Re: Aren't spinlocks missing a memory clobber? [Was: ext2fs crashes lately]

2008-08-02 Thread Roland McGrath
Yes, I think there should be memory clobbers. I added them in libc.

Aren't spinlocks missing a memory clobber? [Was: ext2fs crashes lately]

2008-08-01 Thread Samuel Thibault
Barry deFreese, le Thu 24 Jul 2008 22:19:16 -0400, a écrit : > ext2fs.static: > /var/tmp/hurd-20071119/build-tree/hurd/libports/port-ref.c:31:ports_port_ref: > Assertion 'pi->refcnt || pi->weakrefcnt' failed. Quite odd. I had a closer look at the locking functions, and I noticed that spin_*lock

ext2fs crashes lately

2008-07-24 Thread Barry deFreese
Hi folks, With all of the gnumach builds I have been doing on goober lately, I keep seeing ext2fs.static crashes about every third day. Today I got the following: ext2fs.static: /var/tmp/hurd-20071119/build-tree/hurd/libports/port-ref.c:31:ports_port_ref: Assertion 'pi->refcnt || pi->weakre