On Tue, Jul 08, 2003 at 12:28:30AM +0200, Marco Gerards wrote:
> Here is a patch so users can select the mode to use in vga:
>
> * 512 font slots, less colors.
> * 256 font slots, all colors.
Good, that's needed. However, I think that the option should be named
differently, because there are jus
On Mon, Jul 14, 2003 at 09:00:48PM +0200, Marco Gerards wrote:
> Here is the next version of my patch.
That looks fine. I flipped the logic, though, having a variable
vga_display_max_glyphs which can then be implicitely initialized to 0
(this makes the binary slightly smaller). Should be checked
Looks fine now. Execpt maybe the first entry in the ChangeLog, it
says "New global variable vga_display_max_colors", and it should be
"(vga_display_max_colors): New global variable." But other then that,
its just dandy.
___
Bug-hurd mailing list
[EMAI
Here is the next version of my patch.
I've made some modifications as Marcus and Alfred proposed (thanks for
the comments btw. :)).
Thanks,
Marco
2003-07-14 Marco Gerards <[EMAIL PROTECTED]>
* vga.c: New global variable vga_display_max_colors.
(parse_startup_args): New macro P
Marco Gerards <[EMAIL PROTECTED]> writes:
> > Left from debugging?
>
> No, what makes you think this?
Please ignore my last mail. (I'm an idiot). I'll change this too.
Thanks,
Marco
___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/ma
Marcus Brinkmann <[EMAIL PROTECTED]> writes:
> I think that you have been right, and full color should be the default.
> The corresponding other option would be --max-glyphs, and for
> consistency full color should be renamed to --max-colors.
> Both options should be implemented so you can clearly
"Alfred M. Szmidt" <[EMAIL PROTECTED]> writes:
> Just some minor nit-picks. Overall the patch looks ok.
>
>@@ -62,6 +62,9 @@ static char *vga_display_font_bold;
> "/lib/hurd/fonts/vga-system-bold-italic.bdf"
> static char *vga_display_font_bold_italic;
>
>+/* Use all colors
Marco Gerards <[EMAIL PROTECTED]> schrieb:
> Marcus Brinkmann <[EMAIL PROTECTED]> writes:
> > On Tue, Jul 08, 2003 at 12:28:30AM +0200, Marco Gerards wrote:
> > > Here is a patch so users can select the mode to use in vga:
> > >
> > > * 512 font slots, less colors.
> > > * 256 font slots, all colo
Just some minor nit-picks. Overall the patch looks ok.
@@ -62,6 +62,9 @@ static char *vga_display_font_bold;
"/lib/hurd/fonts/vga-system-bold-italic.bdf"
static char *vga_display_font_bold_italic;
+/* Use all colors when set, otherwise use double font slots. */
+static i
Marcus Brinkmann <[EMAIL PROTECTED]> writes:
> On Tue, Jul 08, 2003 at 12:28:30AM +0200, Marco Gerards wrote:
> > Here is a patch so users can select the mode to use in vga:
> >
> > * 512 font slots, less colors.
> > * 256 font slots, all colors.
>
> Good, that's needed. However, I think that t
Marcus Brinkmann <[EMAIL PROTECTED]> writes:
> On Tue, Jul 08, 2003 at 12:28:30AM +0200, Marco Gerards wrote:
> > Here is a patch so users can select the mode to use in vga:
> >
> > * 512 font slots, less colors.
> > * 256 font slots, all colors.
>
> Good, that's needed. However, I think that t
On Tue, Jul 08, 2003 at 12:28:30AM +0200, Marco Gerards wrote:
> Here is a patch so users can select the mode to use in vga:
>
> * 512 font slots, less colors.
> * 256 font slots, all colors.
Good, that's needed. However, I think that the option should be named
differently, because there are jus
Hi,
Here is a patch so users can select the mode to use in vga:
* 512 font slots, less colors.
* 256 font slots, all colors.
Because many people were confused by it, because it is default on most
systems I set the default amount of font slots to 256. After applying
this patch use:
"-d vga --font
13 matches
Mail list logo
