Re: argp patch for the console client

2004-03-12 Thread Marco Gerards
"Alfred M. Szmidt" <[EMAIL PROTECTED]> writes: > Out of curiousity, could you add a quick comment about why the code > you disabled got disabled (vga_display_change_font)? It is not used and only causes a warning. There are chances that this code will be used later. -- Marco

Re: argp patch for the console client

2004-03-11 Thread Alfred M. Szmidt
But still I don't advise using it because argp is not reentrant yet. Yes it is, as of about 2004-03-09, 10:28:13. :-) ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd

Re: argp patch for the console client

2004-03-11 Thread Alfred M. Szmidt
I looked at the patch quickly, and you missed a couple ChangeLog entries. For example, you didn't document the (small) change you did in beep_on(), you didn't document the interface in ncursesw.c for ncursesw_driver_init(), or the one you did in pc-kbd.c for pc_kbd_init(). There are probobly other

argp patch for the console client

2004-03-09 Thread Marco Gerards
Hi, Here is a patch that adds support for argp argument parsing from console client plugins. I've also changed the existing plugins to do so. And as a bonus I've done task #2479: "Generic Speaker Bell Style Option". I've also fixed all warnings and changed a function call in ncursesw. This fixe