Hi!
On Wed, 29 May 2013 15:53:24 -0700 (PDT), Roland McGrath
wrote:
> > + /* Avoid warning: case value '0' not in enumerated type 'error_t'. */
> > + ESUCCESS = 0,
>
> I don't think this is the right comment. If anybody reads this comment at
> all, that doesn't tell them much. Perhaps so
> I'd suggest to go with the simple ESUCCESS instead of spending some more
> months ;-) thinking about a "more suitable" name.
That is indisputably reasonable, but I did just find myself spending a few
minutes thinking about what name would be more suitable. ;-)
> + /* Avoid warning: case v
Hi!
On Tue, 24 Jul 2012 11:39:02 +0200, I wrote:
> On Mon, 23 Jul 2012 21:29:42 -0400, Barry deFreese
> wrote:
> > How about ENOERR?? :) Sorry, couldn't resist.
>
> If going that route, I'd prefer ESUCCESS -- in spirit of Mach's
> KERN_SUCCESS, D_SUCCESS (devices), ERR_SUCCESS (from , of
> typ
Hi!
On Mon, 23 Jul 2012 21:29:42 -0400, Barry deFreese wrote:
> How about ENOERR?? :) Sorry, couldn't resist.
If going that route, I'd prefer ESUCCESS -- in spirit of Mach's
KERN_SUCCESS, D_SUCCESS (devices), ERR_SUCCESS (from , of
type mach_error_t, also known as err_none -- but neither of whi
How about ENOERR?? :) Sorry, couldn't resist.
BTW, Thomas has a listing of several of the errors/warnings listed here:
http://www.gnu.org/software/hurd/open_issues/glibc.html#index1h1
I'm certainly fine with just adding a value for 0.
Thanks for taking the time to reply.
Barry
On 7/23/2012 3:
Grepping for 'case 0:' shows exactly 8 places where this warning
should arise. One of those is the __hurd_fail inline in hurd.h, so
that one instance probably generates the warning in many
compilations.
Most of these are switches with only a few cases where it would be
easy to just change them to