Re: The patch of pfinet

2008-08-15 Thread zhengda
[EMAIL PROTECTED] wrote: Hi, On Wed, Aug 13, 2008 at 12:07:50PM +0200, zhengda wrote: for (in = h->interfaces; in < h->interfaces + h->num_interfaces; in++) - if (strcmp (in->device->name, arg) == 0) +if (strcmp (in->name, arg) == 0) Wrong inde

Re: The patch of pfinet

2008-08-14 Thread olafBuddenhagen
Hi, On Wed, Aug 13, 2008 at 12:07:50PM +0200, zhengda wrote: >>> for (in = h->interfaces; in < h->interfaces + h->num_interfaces; in++) >>> - if (strcmp (in->device->name, arg) == 0) >>> +if (strcmp (in->name, arg) == 0) >>> >> >> Wrong indentation. >> > I think th

Re: The patch of pfinet

2008-08-13 Thread Samuel Thibault
zhengda, le Wed 13 Aug 2008 12:07:50 +0200, a écrit : > I think the problem is that my vim always uses space instead of tab. and > the displaying result also depends on how your editor display tab. > The tab stops 8 columns in my vim. :set noexpandtab Samuel

Re: The patch of pfinet

2008-08-13 Thread zhengda
[EMAIL PROTECTED] wrote: + master_device = file_name_lookup (master_device_file , 0 , 0); + if (master_device == MACH_PORT_NULL) +error (2, 0, "file_name_lookup %s", master_device_file); Doesn't file_name_lookup() set errno?... The funny thing here is that gcc always c

Re: The patch of pfinet

2008-08-13 Thread olafBuddenhagen
Hi, On Tue, Aug 12, 2008 at 03:52:58PM +0200, zhengda wrote: > pfinet1.patch. To make it open the virtual network interface. > pfinet2.patch. To use the proper filter rule in pfinet. > pfinet3.patch. To enable ioctl to set the network device into the > promiscuous mode. Would be nice for the f

Re: The patch of pfinet

2008-08-12 Thread zhengda
[EMAIL PROTECTED] wrote: Hi, On Fri, Aug 08, 2008 at 08:09:24AM +0200, zhengda wrote: The patch enables the pfinet to work with the multiplexer and use the filter rule that only accepts the packet whose destination is the pfinet server. This rather sounds like two totally orthogonal

Re: The patch of pfinet

2008-08-12 Thread zhengda
[EMAIL PROTECTED] wrote: I don't know the rule either, if there is any... But it just seems reasonable to be consistent and use the same error code for an equivalent error condition... OK. Do you have any idea to prevent the mail client to do it? I use thunderbird. I didn't find anything tha

Re: The patch of pfinet

2008-08-11 Thread olafBuddenhagen
Hi, On Mon, Aug 11, 2008 at 05:56:40PM +0200, zhengda wrote: > [EMAIL PROTECTED] wrote: >> On Fri, Aug 08, 2008 at 08:09:24AM +0200, zhengda wrote: >>> - err = get_privileged_ports (0, &master_device); >>> - if (err) >>> -error (2, err, "cannot get device master port"); >>> + if (master_de

Re: The patch of pfinet

2008-08-11 Thread zhengda
[EMAIL PROTECTED] wrote: Hi, On Fri, Aug 08, 2008 at 08:09:24AM +0200, zhengda wrote: The patch enables the pfinet to work with the multiplexer and use the filter rule that only accepts the packet whose destination is the pfinet server. This rather sounds like two totally orthogonal

Re: The patch of pfinet

2008-08-09 Thread olafBuddenhagen
Hi, On Fri, Aug 08, 2008 at 08:09:24AM +0200, zhengda wrote: > The patch enables the pfinet to work with the multiplexer and use the > filter rule that only accepts the packet whose destination is the > pfinet server. This rather sounds like two totally orthogonal changes, that really should go

Re: The patch of pfinet

2008-08-07 Thread zhengda
The new ChangeLog for the patch. *Makefile: Compile pcap_filter.c *ethernet.c: Open the virtual network device. (ether_filter): Use the bpf filter. (ethernet_open): Open the virtual network device if the user specifies one. (ethernet_reset_filter, ethernet_reset_ipfilter): New fu