Re: [PATCH 3/4] pci-arbiter: Fix a -Wstringop-truncation warning

2019-11-09 Thread Joan Lledó
Hi, El 3/11/19 a les 17:47, Samuel Thibault ha escrit: > The memset still seems spurious to me, isn't it? > Yes, I wrote it to ensure a '\0' was written at the end of the string, no matter its size. But if snprintf() already null terminates, then there's no need for the memset().

Re: [PATCH 3/4] pci-arbiter: Fix a -Wstringop-truncation warning

2019-11-03 Thread Samuel Thibault
James Clarke, le dim. 03 nov. 2019 16:38:50 +, a ecrit: > On 3 Nov 2019, at 16:20, Samuel Thibault wrote: > > Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 > > 10:38:28 +0100, a ecrit: > >> @@ -206,7 +208,7 @@ create_fs_tree (struct pcifs * fs) > >> e_stat = list->

Re: [PATCH 3/4] pci-arbiter: Fix a -Wstringop-truncation warning

2019-11-03 Thread James Clarke
On 3 Nov 2019, at 16:20, Samuel Thibault wrote: > > Hello, > > Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 10:38:28 > +0100, a ecrit: >> * pci-arbiter/pcifs.c: >>* create_dir_entry: >> Limit to NAME_SIZE-1 when calling strncpy(). >> Fin

Re: [PATCH 3/4] pci-arbiter: Fix a -Wstringop-truncation warning

2019-11-03 Thread Samuel Thibault
Hello, Joan Lledó via Bug reports for the GNU Hurd, le dim. 03 nov. 2019 10:38:28 +0100, a ecrit: > * pci-arbiter/pcifs.c: > * create_dir_entry: > Limit to NAME_SIZE-1 when calling strncpy(). > Finish entry->name with '\0'. > * create_fs_tree: >