Re: [PATCH 2/3] Implement mountee startup.

2009-12-26 Thread olafBuddenhagen
Hi, On Sat, Dec 26, 2009 at 05:01:30PM +0100, Carl Fredrik Hammar wrote: > On Wed, Dec 09, 2009 at 03:07:59PM +0100, olafbuddenha...@gmx.net wrote: > > For the record: We agreed on IRC that rather than changing the assert, > > it's better to go back to the original code, i.e. do the check/EPERM >

Re: [PATCH 2/3] Implement mountee startup.

2009-12-26 Thread Carl Fredrik Hammar
Hi, On Wed, Dec 09, 2009 at 03:07:59PM +0100, olafbuddenha...@gmx.net wrote: > On Tue, Dec 08, 2009 at 08:53:46PM +0200, Sergiu Ivanov wrote: > > On Sun, Nov 22, 2009 at 09:05:16PM +0100, olafbuddenha...@gmx.net wrote: > > > On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > > > > >

Re: [PATCH 2/3] Implement mountee startup.

2009-12-10 Thread Sergiu Ivanov
Hello, On Wed, Dec 09, 2009 at 03:07:59PM +0100, olafbuddenha...@gmx.net wrote: > > I'll just assume that the rest of the patch is also fine now, rather > than looking through the whole thing again... I looked at it many times > already; and even though it seems I'm spotting new things to nitpick

Re: [PATCH 2/3] Implement mountee startup.

2009-12-09 Thread olafBuddenhagen
Hi, On Tue, Dec 08, 2009 at 08:53:46PM +0200, Sergiu Ivanov wrote: > On Sun, Nov 22, 2009 at 09:05:16PM +0100, olafbuddenha...@gmx.net wrote: > > On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > > > + /* Fetch the effective UIDs of the unionfs process. */ > > > + nuids = geteui

Re: [PATCH 2/3] Implement mountee startup.

2009-12-03 Thread Carl Fredrik Hammar
Hi, On Sat, Nov 28, 2009 at 12:36:07AM +0100, olafbuddenha...@gmx.net wrote: > On Wed, Nov 25, 2009 at 07:59:33PM +0100, Carl Fredrik Hammar wrote: > > On Sun, Nov 22, 2009 at 09:05:16PM +0100, olafbuddenha...@gmx.net wrote: > > > On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > >

Re: [PATCH 2/3] Implement mountee startup.

2009-12-02 Thread olafBuddenhagen
Hi, On Wed, Nov 25, 2009 at 07:59:33PM +0100, Carl Fredrik Hammar wrote: > On Sun, Nov 22, 2009 at 09:05:16PM +0100, olafbuddenha...@gmx.net wrote: > > On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > > > + /* Fetch the effective UIDs of the unionfs process. */ > > > + nuids =

Re: [PATCH 2/3] Implement mountee startup.

2009-11-25 Thread Carl Fredrik Hammar
Hi, On Sun, Nov 22, 2009 at 09:05:16PM +0100, olafbuddenha...@gmx.net wrote: > On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > > > + /* Fetch the effective UIDs of the unionfs process. */ > > + nuids = geteuids (0, 0); > > + if (nuids < 0) > > +return EPERM; > > + uids =

Re: [PATCH 2/3] Implement mountee startup.

2009-11-25 Thread olafBuddenhagen
Hi, On Thu, Nov 19, 2009 at 10:28:37AM +0200, Sergiu Ivanov wrote: > + /* Fetch the effective UIDs of the unionfs process. */ > + nuids = geteuids (0, 0); > + if (nuids < 0) > +return EPERM; > + uids = alloca (nuids * sizeof (uid_t)); > + > + nuids = geteuids (nuids, uids); > + assert

Re: [PATCH 2/3] Implement mountee startup.

2009-11-18 Thread olafBuddenhagen
Hi, On Tue, Nov 17, 2009 at 11:51:21AM +0200, unlimitedscol...@gmail.com wrote: > On Thu, Nov 05, 2009 at 12:29:54PM +0100, olafbuddenha...@gmx.net > wrote: > > > On Thu, Oct 29, 2009 at 06:37:54AM +0100, olafbuddenha...@gmx.net > > > wrote: > > > > Well, I can't really give a final ACK without s

Re: [PATCH 2/3] Implement mountee startup.

2009-11-17 Thread unlimitedscolobb
Hello, On Thu, Nov 05, 2009 at 12:29:54PM +0100, olafbuddenha...@gmx.net wrote: > On Wed, Nov 04, 2009 at 10:10:43PM +0200, Sergiu Ivanov wrote: > > On Thu, Oct 29, 2009 at 06:37:54AM +0100, olafbuddenha...@gmx.net > > wrote: > > > > Well, I can't really give a final ACK without seeing the whole p

Re: [PATCH 2/3] Implement mountee startup.

2009-11-09 Thread Carl Fredrik Hammar
Hi, On Thu, Nov 05, 2009 at 12:29:54PM +0100, olafbuddenha...@gmx.net wrote: > > > > > > Why are you passing O_READ, anyways?... > > > > > > > > The flags which I pass to start_mountee are used in opening the > > > > port to the root node of the mountee. (I'm sure you've noticed > > > > this; I

Re: [PATCH 2/3] Implement mountee startup.

2009-11-08 Thread olafBuddenhagen
Hi, On Wed, Nov 04, 2009 at 10:10:43PM +0200, Sergiu Ivanov wrote: > On Thu, Oct 29, 2009 at 06:37:54AM +0100, olafbuddenha...@gmx.net > wrote: > > On Mon, Aug 17, 2009 at 07:15:09PM +0300, Sergiu Ivanov wrote: > > > I won't submit patch with corrections you mention in this E-mail > > > right awa