Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Flavio Cruz, on Thu 31 Dec 2015 16:45:51 +0100, wrote: > Agreed. I think only devnode should include it in mig-mutate.h. For > term, only some stubs are including mig-mutate.h. For trans, there's no > mig-mutate.h at all. Here's the modified patch. Applied, thanks! Samuel

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Justus Winter, on Thu 31 Dec 2015 16:28:14 +0100, wrote: > Quoting Samuel Thibault (2015-12-31 16:11:30) > > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > > This fixes three compiler warnings about ports_payload_get_name. > > > > > > * devnode/Makefile: Define DEVICE_IMPORTS. > > > *

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Flavio Cruz
On Thu, Dec 31, 2015 at 04:28:14PM +0100, Justus Winter wrote: > Quoting Samuel Thibault (2015-12-31 16:11:30) > > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > > This fixes three compiler warnings about ports_payload_get_name. > > > > > > * devnode/Makefile: Define DEVICE_IMPORTS. >

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Justus Winter
Quoting Samuel Thibault (2015-12-31 16:11:30) > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > This fixes three compiler warnings about ports_payload_get_name. > > > > * devnode/Makefile: Define DEVICE_IMPORTS. > > * term/Makefile: Likewise. > > * trans/Makefile: Likewise. > > Why not

Re: [PATCH] Use DEVICE_IMPORTS to include libports/ports.h

2015-12-31 Thread Samuel Thibault
Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > This fixes three compiler warnings about ports_payload_get_name. > > * devnode/Makefile: Define DEVICE_IMPORTS. > * term/Makefile: Likewise. > * trans/Makefile: Likewise. Why not adding them to the corresponding mig-mutate.h? Samuel