Re: Patch for setting the keyboard LEDs state

2004-02-02 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: > Marcus Brinkmann <[EMAIL PROTECTED]> writes: > > > On Fri, Jan 30, 2004 at 07:21:15PM +0100, Marco Gerards wrote: > > > The ttychars call checks if the tty is not initialized yet with: > > > > > > if ((tp->t_flags & TS_INIT) == 0) { > > > ... > > >

Re: Patch for setting the keyboard LEDs state

2004-01-30 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > On Fri, Jan 30, 2004 at 07:21:15PM +0100, Marco Gerards wrote: > > The ttychars call checks if the tty is not initialized yet with: > > > > if ((tp->t_flags & TS_INIT) == 0) { > > ... > > tp->t_state |= TS_INIT; > > } > > That's what I meant. L

Re: Patch for setting the keyboard LEDs state

2004-01-30 Thread Marcus Brinkmann
On Fri, Jan 30, 2004 at 07:21:15PM +0100, Marco Gerards wrote: > The ttychars call checks if the tty is not initialized yet with: > > if ((tp->t_flags & TS_INIT) == 0) { > ... > tp->t_state |= TS_INIT; > } That's what I meant. Looks good. Ok for me now, Marcus -- `Rhubarb is no Egyptian

Re: Patch for setting the keyboard LEDs state

2004-01-30 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > BTW, the changelog entry has the dirname in it. For subdir changelogs this > isn't needed. Right, I forgot the Hurd has subdir changelogs. I've changed this. > Then I think you lacked a changelog entry for it. I didn't check that part > of the pa

Re: Patch for setting the keyboard LEDs state

2004-01-30 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > Second, you have your keyboard fix in this patch, so take care not to check > it in accidentially. I do want to check this in with this patch, I will update the autoconf patch when this change is in CVS. > Third, in your acupdate diff I spotted: > +

Re: Patch for setting the keyboard LEDs state

2004-01-29 Thread Marcus Brinkmann
On Thu, Jan 29, 2004 at 06:41:20PM +0100, Marco Gerards wrote: > > Also put the code to change the LED for GNUMach into an #ifdef KDSETLEDS, > > so that compiles with old headers don't fail. > > I defined KDSETLED macro in pc_kbd.c (just like you did for the other > macros). This makes compiling

Re: Patch for setting the keyboard LEDs state

2004-01-29 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > On Thu, Jan 29, 2004 at 02:09:46AM +0100, Marco Gerards wrote: > > Hi, > > > > I put a patch (#2543) on savannah to change the keyboard LEDs state in > > GNUMach. This can be used with device_set_status. I've also put a > > patch on savannah so the

Re: Patch for setting the keyboard LEDs state

2004-01-29 Thread Alfred M. Szmidt
If you want me to send the patch here, just ask me. I'll ask you then, could you send them to the list? Cheers. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd

Re: Patch for setting the keyboard LEDs state

2004-01-29 Thread Marcus Brinkmann
On Thu, Jan 29, 2004 at 02:09:46AM +0100, Marco Gerards wrote: > Hi, > > I put a patch (#2543) on savannah to change the keyboard LEDs state in > GNUMach. This can be used with device_set_status. I've also put a > patch on savannah so the keyboard driver (pc_kbd) of the Hurd console > can use th

Patch for setting the keyboard LEDs state

2004-01-28 Thread Marco Gerards
Hi, I put a patch (#2543) on savannah to change the keyboard LEDs state in GNUMach. This can be used with device_set_status. I've also put a patch on savannah so the keyboard driver (pc_kbd) of the Hurd console can use this. Both patches are in the same file, including changelog entries. If yo