Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-06 Thread Svante Signell
On Wed, 2016-01-06 at 03:25 +0100, Guillem Jover wrote: > On Tue, 2016-01-05 at 06:56:37 +0100, Svante Signell wrote: > >  > $ apt-cache show perl|grep Essential > Build-Essential: yes > `--- > > Is there more perl code in upstream Hurd? If not, how about rewrite this > > code > > snippet in C and

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-06 Thread Samuel Thibault
Svante Signell, on Wed 06 Jan 2016 10:00:57 +0100, wrote: > (Samuel, how's the sound and USB presentation progressing for FOSDEM > 2016?) Hasn't progressed so far. Way too many other things to do with short deadlines. Samuel

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-06 Thread Svante Signell
On Wed, 2016-01-06 at 08:34 +0100, Samuel Thibault wrote: > Guillem Jover, on Wed 06 Jan 2016 03:25:27 +0100, wrote: > > $ apt-cache show perl-base|grep Essential > > Essential: yes > > $ apt-cache show perl|grep Essential > > Build-Essential: yes > > Ah, I was wondering. I knew that perl was not

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Samuel Thibault
Guillem Jover, on Wed 06 Jan 2016 03:25:27 +0100, wrote: > $ apt-cache show perl-base|grep Essential > Essential: yes > $ apt-cache show perl|grep Essential > Build-Essential: yes Ah, I was wondering. I knew that perl was not essential, but didn't know perl was build-essential. Anyway, it's point

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Guillem Jover
On Tue, 2016-01-05 at 06:56:37 +0100, Svante Signell wrote: > BTW: Why does Hurd contain such crappy dependencies such as perl. This comment seems unnecessarily abrasive and out of place… > Is this part of upstream or Debian specific? The Debian package does not > have it: > apt-cache showsrc hu

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Samuel Thibault
Svante Signell, on Tue 05 Jan 2016 14:49:40 +0100, wrote: > On 5 Jan 2016 13:27, "Samuel Thibault" <[1]samuel.thiba...@gnu.org> wrote: > > > > > Well, the source is from the Hurd package, not netdde. It's in  > > > hurd_0.7.orig-libdde-linux26.tar.bz2 > > > > See the file name. > > And since this

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Svante Signell
On 5 Jan 2016 13:27, "Samuel Thibault" wrote: > > > Well, the source is from the Hurd package, not netdde. It's in > > hurd_0.7.orig-libdde-linux26.tar.bz2 > > See the file name. And since this tarball is part of the hurd source it should depend on perl. (that part you edited away from my mail)

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Richard Braun
On Mon, Jan 04, 2016 at 11:09:00PM +0100, Svante Signell wrote: > On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote: > > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > > > - @val = @{$canned_values{$hz}}; > > > - if (!defined(@val)) { > > > - @val = compute_values($hz);

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-05 Thread Samuel Thibault
Svante Signell, on Tue 05 Jan 2016 08:30:51 +0100, wrote: > On Tue, 2016-01-05 at 17:36 +1100, William ML Leslie wrote: > > On 5 January 2016 at 16:56, Svante Signell wrote: > > > BTW: Why does Hurd contain such crappy dependencies such as perl. Is this > > > part > > > of upstream or Debian speci

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Tue, 2016-01-05 at 17:36 +1100, William ML Leslie wrote: > On 5 January 2016 at 16:56, Svante Signell wrote: > > BTW: Why does Hurd contain such crappy dependencies such as perl. Is this > > part > > of upstream or Debian specific? The Debian package does not have it: > > apt-cache showsrc hurd

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread William ML Leslie
On 5 January 2016 at 16:56, Svante Signell wrote: > BTW: Why does Hurd contain such crappy dependencies such as perl. Is this part > of upstream or Debian specific? The Debian package does not have it: > apt-cache showsrc hurd | grep Build-Depends | grep -i perl > > Is there more perl code in ups

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Mon, 2016-01-04 at 22:38 +, James Clarke wrote: > On 4 Jan 2016, at 22:13, Samuel Thibault wrote: > > Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: > > It is indeed just !@val (this use of defined was deprecated in 5.6.1 and > raised warnings since 5.16[1]). Here's the simplifi

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
James Clarke, on Mon 04 Jan 2016 22:38:28 +, wrote: > > - if (!defined(@val)) { > > + if (!@val) { Applied, thanks! Samuel

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread James Clarke
On 4 Jan 2016, at 22:13, Samuel Thibault wrote: > Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: >> Obviously the !defined(@val) is >> no longer allowed, and I don't know how to rewrite that condition. > > Perhaps juste !@val? > I have no idea, I don't know perl. But probably worth try

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
Svante Signell, on Mon 04 Jan 2016 23:09:00 +0100, wrote: > On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote: > > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > > > - @val = @{$canned_values{$hz}}; > > > - if (!defined(@val)) { > > > - @val = compute_values($hz); > > >

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
On Mon, 2016-01-04 at 22:50 +0100, Samuel Thibault wrote: > Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > > - @val = @{$canned_values{$hz}}; > > - if (!defined(@val)) { > > - @val = compute_values($hz); > > - } > > + @val = compute_values($hz); > > Don't we want to

Re: PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Samuel Thibault
Svante Signell, on Mon 04 Jan 2016 22:02:02 +0100, wrote: > - @val = @{$canned_values{$hz}}; > - if (!defined(@val)) { > - @val = compute_values($hz); > - } > + @val = compute_values($hz); Don't we want to still try to use canned_values? Samuel

PATCH: Hurd FTBFS with perl 5.22

2016-01-04 Thread Svante Signell
Hi, The following patch is sufficient to make Debian GNU/Hurd build again with the latest perl 5.22.1-1: Index: hurd-0.7/libdde-linux26/lib/src/kernel/timeconst.pl === --- hurd-0.7.orig/libdde-linux26/lib/src/kernel/timeconst.pl +++