> Thomas Schwinge writes:
> On Tue, 27 Nov 2012 16:36:24 +0700, Ivan Shmakov wrote:
[…]
>> Here, a diff line could've been saved by adding an opening { to the
>> if above. (IOW, no need to drop the C grouping construct from
>> here.)
> Generally you're right with your suggestions (
Hi Ivan!
On Tue, 27 Nov 2012 16:36:24 +0700, Ivan Shmakov wrote:
> > Thomas Schwinge writes:
>
> […]
>
> > Does anyone spot any problems, or does this need more testing, or is
> > it OK to commit right away?
>
> I see none (but then, I'm not really a Mach or ATA expert),
> a
On Tue, Nov 27, 2012 at 04:36:24PM +0700, Ivan Shmakov wrote:
> > Thomas Schwinge writes:
>
> […]
>
> > Does anyone spot any problems, or does this need more testing, or is
> > it OK to commit right away?
>
> I see none (but then, I'm not really a Mach or ATA expert),
> apart
> Thomas Schwinge writes:
[…]
> Does anyone spot any problems, or does this need more testing, or is
> it OK to commit right away?
I see none (but then, I'm not really a Mach or ATA expert),
apart from a few style and formatting issues.
[…]
> +if (id->cyls == 16383
Hi!
GNU Mach mis-detected a 64 GB LBA-capable IDE disk drive. As elaborated
in the patch: »The ATA spec tells large drives to return C/H/S =
16383/16/63 independent of their size. Some drives can be jumpered to
use 15 heads instead of 16.« My hd2 claimed 15 heads even without any
(visible) jump
