Re: Atomic file locking update

2014-11-27 Thread Samuel Thibault
Svante Signell, le Thu 27 Nov 2014 19:25:54 +0100, a écrit : > On Thu, 2014-11-27 at 15:56 +0100, Samuel Thibault wrote: > > Svante Signell, le Thu 27 Nov 2014 13:49:53 +0100, a écrit : > > > As discussed on IRC too, AIUI the record locking patches just get rid > > of the whole content that I'm pa

Re: Atomic file locking update

2014-11-27 Thread Svante Signell
On Thu, 2014-11-27 at 15:56 +0100, Samuel Thibault wrote: > Svante Signell, le Thu 27 Nov 2014 13:49:53 +0100, a écrit : > As discussed on IRC too, AIUI the record locking patches just get rid > of the whole content that I'm patching. So the rebase should be quite > trivial: just tell git to keep

Re: Atomic file locking update

2014-11-27 Thread Samuel Thibault
Svante Signell, le Thu 27 Nov 2014 13:49:53 +0100, a écrit : > As discussed on #debian-hurd IRC, these changes are conflicting with the > record file locking patches. When you upgrade Hurd again, I need to > rebase these patches another time. As discussed on IRC too, AIUI the record locking patche

Re: Atomic file locking update

2014-11-27 Thread Svante Signell
On Thu, 2014-11-27 at 13:20 +0100, Samuel Thibault wrote: > Justus Winter, le Thu 27 Nov 2014 12:51:56 +0100, a écrit : > > Just to be sure I understand the change correctly, the downgrade is > > somewhat trivial, right? > > Yes, we just have to notify potential writers. > > > Because your patch

Re: Atomic file locking update

2014-11-27 Thread Samuel Thibault
Justus Winter, le Thu 27 Nov 2014 12:51:56 +0100, a écrit : > Just to be sure I understand the change correctly, the downgrade is > somewhat trivial, right? Yes, we just have to notify potential writers. > Because your patch has an explicit 'tell > others we are upgrading' and my symmetry-sense i

Re: Atomic file locking update

2014-11-27 Thread Justus Winter
Hi :) Quoting Samuel Thibault (2014-11-23 17:38:32) > Hello, > > While Svante is working on the record locking, I have worked on at > least fixing whole file locking: there was one bug in our current > implementation: flock(LOCK_SH); flock(LOCK_EX);, as per POSIX, does not > guarantee an atomic u

Atomic file locking update

2014-11-23 Thread Samuel Thibault
Hello, While Svante is working on the record locking, I have worked on at least fixing whole file locking: there was one bug in our current implementation: flock(LOCK_SH); flock(LOCK_EX);, as per POSIX, does not guarantee an atomic upgrade from LOCK_SH to LOCK_EX. But fcntl(SETLK,F_RDLCK); fcntl(S