> "Tom" == Tom Tromey writes:
> "Thomas" == Thomas Schwinge writes:
Thomas> + struct cleanup *old_chain = make_cleanup (xfree,
pathname);
Tom> Please don't add new cleanups to gdb.
Tom> We're in the process of removing them all.
Tom> Instead you can use gdb::unique_xmalloc
> "Thomas" == Thomas Schwinge writes:
Thomas> + struct cleanup *old_chain = make_cleanup (xfree,
pathname);
Please don't add new cleanups to gdb.
We're in the process of removing them all.
Instead you can use gdb::unique_xmalloc_ptr, or std::string, or a
std::vector of some fla
Hi!
On Fri, 17 Feb 2017 16:45:01 +, Pedro Alves wrote:
> Only noticed this patch now.
Heh, and I've only now gotten back to completing this. ;-)
> > On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build.
> > (I'm aware that there is other PATH_MAX usage in GDB sources, which
Hi Thomas,
Only noticed this patch now.
> On GNU/Hurd, there is no "#define PATH_MAX", so this fails to build.
> (I'm aware that there is other PATH_MAX usage in GDB sources, which we
> ought to fix at some point, for example in gdbserver -- which is not yet
> enabled for GNU/Hurd.)
>
> OK to pu
Hi!
On Fri, 11 Sep 2015 11:38:15 -0700, Don Breazeal wrote:
> Here is what I pushed.
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -6089,11 +6178,42 @@ Packet: '%s'\n"),
> event->ws.kind = TARGET_WAITKIND_VFORK_DONE;
> p = skip_to_semicolon (p1 + 1);
> }
> +