[patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-12-03 Thread Neal H. Walfield
This mail is an automated notification from the patch tracker of the project: The GNU Hurd. /**/ [patch #3346] Latest Modifications: Changes by: Neal H. Walfield <[EMAIL PROTECTED]> 'Date: F

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Alfred M. Szmidt
Commited. Since this enables asserts, please report any you hit; they are bugs and should be fixed. 2004-11-22 Guillem Jover <[EMAIL PROTECTED]> * bogus/mach_assert.h: Change #ifdef DEBUG to #ifndef NDEBUG for assert et al. * kern/assert.h: Likewise. * kern/debu

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Alfred M. Szmidt
Commited. 2004-09-07 Neal H. Walfield <[EMAIL PROTECTED]> * linux/dev/glue/block.c (__brelse): Unconditionally kfree BH. (getblk): Unconditionally kalloc BH. * kern/kalloc.c [!NDEBUG] (kalloc_init_called): New static variable. (kalloc_init): Assert that

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Roland McGrath
> Roland, OK to commit? Then I can commit the previous patch with a > good concious; after I test it obviously... ok. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Alfred M. Szmidt
Sounds like it might be this [1] patch. Thanks, I inlined it. Roland, OK to commit? Then I can commit the previous patch with a good concious; after I test it obviously... Summary: Double free and memory loss probing partition table Original Submission: While GNU Mach reads the partition

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Neal H. Walfield
At Tue, 30 Nov 2004 12:19:22 +0100, Alfred M. Szmidt wrote: > >> I agree with Neal. I can test it before I commit it as Neal >> requested. >> >> Roland, OK to commit? > >That looks fine to me. > > Guillem didn't tell me that this will cause a bunch of asserts to > happen if

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-30 Thread Alfred M. Szmidt
> I agree with Neal. I can test it before I commit it as Neal > requested. > > Roland, OK to commit? That looks fine to me. Guillem didn't tell me that this will cause a bunch of asserts to happen if Neal's patches (no idea which) aren't applied _first_. Infact, the welcome messa

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-29 Thread Roland McGrath
> I agree with Neal. I can test it before I commit it as Neal requested. > > Roland, OK to commit? That looks fine to me. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-29 Thread Alfred M. Szmidt
I agree with Neal. I can test it before I commit it as Neal requested. Roland, OK to commit? Thanks. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-29 Thread Neal H. Walfield
Guillem, This patch looks good. It enables the major debugging machinery without all of the status output that my patch also turned on. I remember that there were some places that did sanity checks in the DEBUG sections (which is why I changed enabled them), however, isolating those from the sta

Re: [patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-11-29 Thread Guillem Jover
Hi, On Tue, Sep 07, 2004 at 10:35:11AM -0400, Neal H. Walfield wrote: > [patch #3346] Full Item Snapshot: > > URL: > Project: The GNU Hurd > Submitted by: Neal H. Walfield > On: Tue 09/07/04 at 14:29 > Category: GNU Mach > Summary:

[patch #3346] GNUMach: ifdef DEBUG -> ifndef NDEBUG

2004-09-07 Thread Neal H. Walfield
This mail is an automated notification from the patch tracker of the project: The GNU Hurd. /**/ [patch #3346] Full Item Snapshot: URL: Project: The GNU Hurd S